Re: [PATCHv3] gdb: resolve class name via DW_AT_signature in cooked index

[Tom Tromey <tom@tromey.com>]

Simon> That's why I was wondering, but really I am not opposed to a flag, I
Simon> just wanted to know the rationale.  We have 1 bit free in
Simon> cooked_index_flag, so it wouldn't take up any more space.

It looks that way because of the underlying type, but that is just a
convenient choice:

(gdb) ptype/o cooked_index_entry
/* offset      |    size */  type = class cooked_index_entry : public allocate_on_obstack<cooked_index_entry> {
                             public:
/*      0      |       8 */    const char *name;
/*      8      |       8 */    const char *canonical;
/*     16      |       4 */    dwarf_tag tag;
/*     20      |       1 */    cooked_index_flag flags;
/*     21: 0   |       4 */    language lang : 5;
/* XXX  3-bit hole       */
/* XXX  2-byte hole      */

We actually have 16 more bits available if we need them.
Though maybe only 8 of those are easily usable.

Tom