Re: [PATCHv3] gdb: resolve class name via DW_AT_signature in cooked index

[Tom Tromey <tom@tromey.com>]

>>> I would much prefer a new cooked_index_flag_enum value over allowing
>>> NULL pointers.
>> 
>> Why?  Just wondering.

Andrew> Also, in this case, the point is that we end up creating the
Andrew> cooked_index_entry before we know the name, so what value should the
Andrew> name pointer hold?

Andrew> So V3 switched to NULL pointers as something that is fairly obviously an
Andrew> "unset" string.

I won't complain.  I just think letting in NULL pointers often ends badly.

Andrew> then 'info complaints' would like each objfile and the number of
Andrew> complaints seen, and 'info complaints <objfile name>' would actually
Andrew> list the complaints for the given objfile.

This might be nicer, but consider that many of the existing complaints
are just somebody's opinion about the compiler output, and not only are
they not actionable, they will not ever be fixed.

My contention is that no complaint has actually ever been fixed by
virtue of being a complaint -- that is, maybe a compiler fix has been
done, but it's been a separate action, not driven by gdb's output.

Basically complaints are worthless.  I won't object if you work on this,
but IMNSHO putting any effort into this is a waste of time.

Tom