Re: [PATCHv3] gdb: resolve class name via DW_AT_signature in cooked index

[Simon Marchi <simark@simark.ca>]

On 2026-09-01 09:31, Andrew Burgess wrote:
> In v3:
> 
>   - I forgot to run check-all-boards on v2.  There were some failures
>     due to GDB's output not matching the patterns, I've fixed what I
>     could in this iteration.
> 
>   - While looking at the different patterns I reworded one of the
>     complaint messages in cooked-index-shard.c to match a warning that
>     is emitted from elsewhere in the DWARF reader.  There's no real
>     functional change, it's just the wording that's updated.
> 
>   - There are still some check-all-boards failures, but I believe
>     these are all wider issues when running DWARF assembler tests
>     using the check-all-boards rule, so I'm ignoring them for now.
> 
> In v2:
> 
>   - Complete rewrite to address the issues that Tom raised.
> 
>   - Rebase to HEAD and retest.
> 
>   - New tests added to cover the DWO case and an error case.
> 
> Thanks,
> Andrew
> 
> ---

I just wanted to point out that your use of --- is the opposite of the
convention, normally the "real" commit message goes above and the
temporary message goes below.  When applying this email as a whole
(either with git-am or b4), it keeps the wrong part as the commit
message.  I would suggest either using the reversed order, or using a
different marker if you prefer to keep the temporary message on top.

Simon