From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NuP/AYPYomoFKz0AWB0awg (envelope-from ) for ; Thu, 10 Sep 2026 12:19:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789057154; bh=VYczPdV0cahJra0giYDmJM7ugYgUPubvGp3pyy8MxwE=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AaCJji0oEeb8zC5bDXyb+pG5a1yG4IydTKVBVL/eAUNo8b67f8o6k3Oy9GE0Oreqd Au7K9Prohw10GJ4cee9UM3COCv5TSgf/D8Va1n74ZpiFcB0JV5qQnQxs6wnp7CLz1c 2om+JW3j1/EiOED0nDJm2eWcCpRNYaWTbvQ5enak= Received: by simark.ca (Postfix, from userid 112) id EC6201E09E; Thu, 10 Sep 2026 12:19:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=X+CxAgvC; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2E94E1E033 for ; Thu, 10 Sep 2026 12:19:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8EC7F48FDCB7 for ; Thu, 10 Sep 2026 16:19:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8EC7F48FDCB7 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=X+CxAgvC Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7CB1E4BA79BB for ; Thu, 10 Sep 2026 16:18:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7CB1E4BA79BB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7CB1E4BA79BB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789057130; cv=none; b=PZOEw+jgmMxmwfgSNHaVEfxDSDQ5KCF/5zFbdutHg5YWxEyJcqBX4anWjUZk88/HvcU5ss7Pik8by4oZdhVjXuvhJuv/kolT1RWZrm7wxg3mSHN3JpTrl+YETP9GGjDRLuzw5xOcS0dx6DF5UsDFJFih/V3edIzTDQ+HxaBnzfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789057130; c=relaxed/simple; bh=VYczPdV0cahJra0giYDmJM7ugYgUPubvGp3pyy8MxwE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=w0ABqQJoaeXyGNPDcREOXXHNa/gJ7xc7A9j8UlQfsOPhnP3CO4jHGYmGXJfYJ04dhvVWbQbXkrsKdRtbV7FNI6YOIx1Uc74A5JjKhrMVOOtkdbX8mdf60IQnIYN5Tmsl+tO8No9ydbE3xUkWNjFEEbi05rWlcOSr344UUCzdrZw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=X+CxAgvC DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7CB1E4BA79BB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789057130; bh=VYczPdV0cahJra0giYDmJM7ugYgUPubvGp3pyy8MxwE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=X+CxAgvC7yRZNwh2BTPRiYADI6uPozk5TeB1zhVttEI/kDA+lN4vME2H4FPJxN9i5 WO7SVdlgrbTXYWLC1Lp+EISrd71t6LLYEVFjyfqkh08qhxMw89hVksZg6/Y//l6ttY 4wrDGg3mRxED68LRd8mCWKmiUlR+uwyhpFCe61js= Received: by simark.ca (Postfix) id 029B71E033; Thu, 10 Sep 2026 12:18:49 -0400 (EDT) Message-ID: <942dfd6e-60d5-4443-bbbc-7d2f67d2ba05@simark.ca> Date: Thu, 10 Sep 2026 12:18:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv3] gdb: resolve class name via DW_AT_signature in cooked index To: Andrew Burgess , gdb-patches@sourceware.org References: <295672ce0ea0bf20911fbbc997f38fe9f62b19be.1787952498.git.aburgess@redhat.com> <897f5eb957bdfd90cd3fd5efa662021ed5c2aef2.1788269262.git.aburgess@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <897f5eb957bdfd90cd3fd5efa662021ed5c2aef2.1788269262.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-09-01 09:31, Andrew Burgess wrote: > In v3: > > - I forgot to run check-all-boards on v2. There were some failures > due to GDB's output not matching the patterns, I've fixed what I > could in this iteration. > > - While looking at the different patterns I reworded one of the > complaint messages in cooked-index-shard.c to match a warning that > is emitted from elsewhere in the DWARF reader. There's no real > functional change, it's just the wording that's updated. > > - There are still some check-all-boards failures, but I believe > these are all wider issues when running DWARF assembler tests > using the check-all-boards rule, so I'm ignoring them for now. > > In v2: > > - Complete rewrite to address the issues that Tom raised. > > - Rebase to HEAD and retest. > > - New tests added to cover the DWO case and an error case. > > Thanks, > Andrew > > --- I just wanted to point out that your use of --- is the opposite of the convention, normally the "real" commit message goes above and the temporary message goes below. When applying this email as a whole (either with git-am or b4), it keeps the wrong part as the commit message. I would suggest either using the reversed order, or using a different marker if you prefer to keep the temporary message on top. Simon