From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wS4cDtPdtWqB/z8AWB0awg (envelope-from ) for ; Thu, 24 Sep 2026 22:34:59 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=cYZuRvLG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 29D5C1E033; Thu, 24 Sep 2026 22:34:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5E5141E033 for ; Thu, 24 Sep 2026 22:34:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8A6A34BB58E2 for ; Fri, 25 Sep 2026 02:34:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A6A34BB58E2 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=cYZuRvLG Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170120003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::3]) by sourceware.org (Postfix) with ESMTPS id 2316A4BB58CA for ; Fri, 25 Sep 2026 02:34:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2316A4BB58CA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2316A4BB58CA Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1790303671; cv=pass; b=fhE/R+hUb6vp/caQbsdkIdF+ZDC78rcLX72XaeqeSzS94jkV+5J+K/A2e9VZW4HWekF9++TMVz3eWohuX6x4ryF7t0l3SFxHCLI1vTvV6JX4V1GOjRrR21d8z6YLyCbzSTWidBUhKHAG1xEgUch6wVuCf9zTg3DMWnIMM1dTfi0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1790303671; c=relaxed/simple; bh=T+N2yIiT6ztKs2B6IGbJfdt30c+TwH+GgsrIYM658TY=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=XkfCMuV/cTxCBMk4KxvBTmn3AtXQ4bfqgIrp68SSa6UGy8huPxQNRD2yYHgX2FUEVjB+iVdksm3WVbT222ITLvpDZF+ye1Vu3+llMI9pj6dj9lA7n+GM7hnHZRyhvu42v82mYq170jhMEnuOdVLcJj0rSFSrYN6LEHa/akI7PVM= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=cYZuRvLG DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2316A4BB58CA ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=siQfcbeqAn1lRXSA6dQNxIBC0H+UJcVOrUdVNkcrKtCKGF9BfMja329kUIdwK/N9XKJRt/EoB0jCiB0gZqj7/pUGC5mM7ihfNZDzjriicWWwE9GjVFjUWkP99DYG4CuDM1Pk8neemRWoEKqMBOipvwq1PDwCEOkloRdstZ3NSQJOR3EuXT0yoBU6rmvIAxGjW8pBp19WfvODHFYC9nyaDn/B+T4OKJzQ2adzX3fsKE46h3EC4uwcRT+WVFrRpWsmDfKK04uCpn3ihbtQoTi84X4TQi8y8mB+5NdRvyoH8NXH2h/aKY/3/e8M7atYzLt99kwh7m+7JJXzAMHnfdQFmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SBWoMzZb+neReTFvgkUxl7QY9J27voo4hHfX9uS02xo=; b=W8rgzZMUc54F0/QC7scwsWVode1abSebiIPEPdjtNDTpTGb0J88YQQbWC4HW4pl7gQytaNK6h+FMgm+Ic5I8srQLpQOzQSuZaNnhI9gec3ippnwLsEhx2Fw6zjOCK1ZsFFQyxiCG/XvfFv//WBEH+cBtZ3xCkn8jVVHR+2TLzvsQy/eCjJSd996fXkjKYuFtmA/Z+KoE7kcuM+MrcrX748BHLX+kMrAe4Rt8+i2kpqGLUbDnTLp9XX7JFa9MopiVthCaTsqHi4UB11ZJZEbhWEYdtkP71neUzyqyVAQG5jCaIIb+jqqYA7Sm/Yp5gxgA2EffKu0ktxFDejmM6FyN9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SBWoMzZb+neReTFvgkUxl7QY9J27voo4hHfX9uS02xo=; b=cYZuRvLGrQ1bYssbgu5C4hCYQfbi4YLPLxEr1I5Qc/0BgXJBjN31kPwQr8vZ1CNrVh3iDrSOekBgkdV4p4OqDpKdqcfwzOcDzUbf1NyccoINSIXu2T2Jmus6TTHm1EgroG6p+1RBN5auCG1oLHEF/lPIo0QLobNPh24HgCvIPRd/OXkP3/TT6KGZRkMXr3moPA36Lw2Kjo02Mgn15pUF3s1Melg5FeesAKGv3R/Q1sKA1uZ0Z8MM1KbU2+Fyg9+hIynN2p5DtRGnPBhSG7vaStwq7ws309o6yu5pu58hEbVSdPrXXAYUP6lFbjEoUDzFwVvMgx47JsGgM+AHwhvIzw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YQ1PR01MB151280.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:ce::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.18; Fri, 25 Sep 2026 02:34:26 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%7]) with mapi id 15.21.0451.014; Fri, 25 Sep 2026 02:34:26 +0000 Message-ID: <883579be-3b65-40b8-9d73-8fbaeb683991@efficios.com> Date: Thu, 24 Sep 2026 22:34:24 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] gdb/dwarf: add cooked_index_entry::parent_is_deferred To: Andrew Burgess , gdb-patches@sourceware.org References: <20260924050002.1539783-1-simon.marchi@efficios.com> <20260924151048.204777-1-simon.marchi@efficios.com> <20260924151048.204777-4-simon.marchi@efficios.com> <87v77u1id8.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87v77u1id8.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0294.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:6d::18) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YQ1PR01MB151280:EE_ X-MS-Office365-Filtering-Correlation-Id: 83ba2e31-ec99-446d-b05c-08df1aad843a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|10070799003|366016|23010399003|376014|4143699003|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: CvHZOH+hGUb/jdkK225bSjT4uvHK948P0W9fTvVBQdaKxhPii9qRa0TAQdyM6V0OrW/htVSADrBYspxXVdvrCxvmNZ3ChdD/4KdCxh4EmCum6bLaA5CMdcD06pcGxubKHRK9E3uoZ40DcONzCzcX3q4mRUDzn34Tf5cCQQ63j1EXjQlMSLFUK0Lnl0flxvy2XGUEVmljXj3ZpL/Q3w/oIy1QJAfQk2keU77Rmv76COQVYR5uEE6rs25SbKPxwf7HW1bjA40lWjrmu58gtgJnFKL4kCgHuz/tSkZ5bmP+IsNxCL7Bai9fUcjbG+p0y7bapJRtGVG8Rj5kfUZwmzuOafIW4OLEnq1tgSXUCJCeM4xlFhOntpmNeYrXmHpiKO9TPu3mWGD3RAKZNVWe5f8vYMG6yYzla8oloKexdwAgaq86yb8Sg4VAkHDvk/tuzIHgueV56S/zlytUiJbwIade2rTvpyIUhIxjRsIG/s5r9Fb/hH6Z9KY8B3j/Tk1biRDGT11/Y77SXRUM4KUKI1m0WAqBb1KuRFGuvMymiQUxf6dGGWmz0jyoc0hPen1RJknYoUvCeIEE9iMwxshmqFK4weZPlRVB7HWv9c8uyNZmXp9MIeM7ac94ClBkHMqE25NbJTBXktjFGdVlEdh5Q/fUXHJkmaz0xYo1s1FZL3ecRW8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(10070799003)(366016)(23010399003)(376014)(4143699003)(10067099003)(56012099006)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzM3WWNlUEo4cUZ2Ulo1cSttZ0pXTEVrUVZzZzA0ZWJvaFpWc2ZSdmdjdmpq?= =?utf-8?B?UlM5dmtIbG9BOWk4WXpScDRZVmt1bTRzUnozT05NTTJIaXdldE1FR1lLK1N0?= =?utf-8?B?aHg5bnBXMVZUMlcxQzRPdUV1WUt2WTd1czRCTldkSktNSDd5S2pkeVdBY3NX?= =?utf-8?B?L2dqeEZqVzJ0SlV0cDNqOURRVExxYjdKQTFHNU1nRU1zL2ZtUWJ1WDFJNkpP?= =?utf-8?B?cWpuWkp2NWxPY0hsa00xYjNsMDRoUWNjKzZMbG82SWJZZG95Y08vM3cvZEYx?= =?utf-8?B?YTQwQzV3VWQzVUs0ekIxZnRuWFZHOHEvQkpUSUp5cTZvSDRoVzVmZnhnMTFJ?= =?utf-8?B?R2orU3R3SWVPWDU3Y0F5TE9xRllnM2pLSnM0dzlMU2o4WUY2a09JU2lNSWw3?= =?utf-8?B?ZWQrUllrcnBnS04veE1iNDBIK0pxNmE4U2NvTVFvNU1DenhNa2Z2bmhabFpu?= =?utf-8?B?SW5EalowOVBvLzRpR1JUL1djd3lPbFBtSnNuSHM5YTdDMVJBejQ5Z29MWmJv?= =?utf-8?B?TzFZc3E4eDZlaXdlc1pmTkhhVjlyVUMzNWNTSlEwbWplZjhqaXIyaU5CTzNi?= =?utf-8?B?eXRUVWx5alcrTlZFRjV5NlF4TFBSVHBkR1ZvRGtoVHh3Wkk1MlFQTFc5ZDRv?= =?utf-8?B?TkM4R2NVRDladEZITUpmS1JjZzZvNklFQitnRmFwTHpiMHpWSXMrZDFXU29Y?= =?utf-8?B?Ni80elRoMUtoSE9zOTZ5VjgzRU95SE5yWHdneUFnNHc0Y2hiTHJIdG5nSVV3?= =?utf-8?B?aGtyQzdLUnMvMHdOUDhocWJ3ZlFYeGg4UEVCbUtEWHJvcFNkVlA3eVFKZjdZ?= =?utf-8?B?MjcrSUE3ZXhhMzBadmRucUE5Ny96Nm10Z3dsMG9RZHRNUDh4dk9mZCtwNlpy?= =?utf-8?B?QzlKdWsrdmFnVVRvVzJnL3NmdUdVVGxQb3ZxM1NwSHhwbnFONXc3V0cwL0hH?= =?utf-8?B?R0FiRkNwdGV2bDFvbllSN0pQOWowcDloUXBMZ09GMEdRYll2SHY3cmszdGk5?= =?utf-8?B?UWVKeFVSK3hNQjB6Tk9iWWx4L0dqMUt3VlM4Sk00bWFkOWgwMEhOR1dUUWtN?= =?utf-8?B?b0xvQXdlSDE5SGxRWkF6WGRKUzg3eWVwK0RSZXN3V3VOMmoxd2R2TFVEdm41?= =?utf-8?B?TUMvV3lWTzNUYUVRR1g2Ri9JbUorWGREV1NTVHNFYjBxdlRJMnp6Smw3U2tm?= =?utf-8?B?Yzl0aXd2RThIVFBheVRKUWdpbkdNbC80by9QblE4am90bWd6SE1NeHl3NjIx?= =?utf-8?B?VkF4d1ZBNEhNYTR6bkdpQ2l5Q2swbmNrTmNVdjlWYkFvMVpHSVVRSXRnOWRR?= =?utf-8?B?Z0M5QjlZVVd3YXIrN1Zrd2F2S2ZwSm9WUXFqSU9WOHdUbUJRbGNDT3VwMENY?= =?utf-8?B?WkI1RHVtUGFoNTY3QzRIbDlwbGV4L0tmRlNOQTdwRUtIcXQ3OEE2b1llVTMr?= =?utf-8?B?cTJsa2VPeU15RHBza2FpK0NHdmREY3l1UDRraHE5RDFqVDNNdklZS1NWSm9E?= =?utf-8?B?OXNoZTJLdnI4dnE1TWdtNFpGcXVBRmsxaFZFaVNNSjA5SXltaWRONFBEL01p?= =?utf-8?B?OXNHTjY0Z3AwaFFoZS93SURzSXYycHBGMjh0T0d0dTRlQ0Q2SkVKZXBkK0t6?= =?utf-8?B?RnVqQ1ljcGVMK0lUUUZaNTY2Y0V2TmJtbEFXWEZ1RXhjb0syNTUyQkUvRk40?= =?utf-8?B?aUlrWHIzQUxydDQ4MUk1a2xDZ1hEWE50Q1pucVNOOXhOeU0reTMxbzR0THg4?= =?utf-8?B?Q3BtdDU1TGljM25mbFZjMTRnR2lEcERNNTVvTk1LV25iYzhkT0hjVnJ0OGI1?= =?utf-8?B?d1ZaQU9aNStOTUhZUEsrWjZLUjlGaEdTVm1Oekc0ZFQybldVdlcwRkZUV3JX?= =?utf-8?B?RU5zZ3RPRHRTWGhsN1lQMXhmZi9USGEwemFVMVB3WXliSFNiQzY3cXlKbmEr?= =?utf-8?B?Z3BrQjNra2NPRlhkWmxwdGdqeUF0QmpOQ2ZoQndZUzJtcEMvbHJPU2t1K2RE?= =?utf-8?B?TmxEb2RhcUFpZVN2YkwrbEo4MUttTEdWYnlDUHYvQ0NYbVhlMno0cktHOHQ4?= =?utf-8?B?ekNNRjdPdmZ4ZkNiT2xCZjYrZ1JxM3hvMTFiMW5qWjV5RVJTWnd1dDFzVUd1?= =?utf-8?B?WGc3OGVtUzRidDNNeVFEc09ZcisrdmxUTVFpSnI3c2F4N0ZFeXlIZllyZGNm?= =?utf-8?B?Tm1vL1dSYSsyaFlaSWthMXdIRHAwcjl0eTM2NCswZFI4alBHUDEvOVAxVVlh?= =?utf-8?B?UHVNZ202MG5ZQ3BHZFlmc2p4b2ExU09jRDFlV0xJblJ6bTBNenZBRmwxNUYy?= =?utf-8?B?Rzh5MFJSUXB3SzMyNzBkSFJFSi8xWkkrWDVaS0xvN0F2STlzenJIb2VmWlB0?= =?utf-8?Q?4bhVRnYzLYYC9KoxPCPrE319VjFlqLurpvtrOOHa2c2P9?= X-MS-Exchange-AntiSpam-MessageData-1: VTZq3cABcFhL7g== X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83ba2e31-ec99-446d-b05c-08df1aad843a X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2026 02:34:26.3344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8fOXQnP+3RWB8nhmg7Z9WLi3hQ9lOnInKnGTrUWJcqwEjAHsvg40wCMnG8Eu0XM3J5VI1fQZdUdqAjhYFx4BOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQ1PR01MB151280 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/24/26 4:53 PM, Andrew Burgess wrote: > > This looks good to me. But because I have to find something to earn my > pay... > > Simon Marchi writes: > >> Add a parent_is_deferred method to cooked_index_entry, mirroring >> name_is_deferred, and use it instead of checkingthe IS_PARENT_DEFERRED > > ... missing space in 'checkingthe'. Fixed. > But otherwise, LGTM: > > Approved-By: Andrew Burgess Thanks, will push to master and gdb-18-branch. Simon