Re: [PATCH 0/5] Set osabi in remote target descriptions

[Andrew Burgess <aburgess@redhat.com>]

Simon Marchi <simark@simark.ca> writes:

> On 2024-10-08 13:11, Andrew Burgess wrote:
>> I tried doing some remote debugging of a Window machine from a Linux
>> machine and ran into some problems caused by gdbserver failing to set
>> the osabi in the target description that is sent to GDB.  This series
>> fixes this issue.
>> 
>> In v2:
>> 
>>   - Patches 3 & 4 are new.  These are refactoring to allow for the
>>     updated patch 5.
>> 
>>   - Patch 5 is mostly the same, except the osabi is now set based on
>>     the enum values, rather than the osabi name strings.
>> 
>> Thanks,
>> Andrew
>
> I'm done sending comments, nothing is a blocker, so feel free to address
> them or not, then:
>
> Approved-By: Simon Marchi <simon.marchi@efficios.com>

I've addressed all the minor issues you raised and pushed this series.

I've not addressed the osabi being set to GNU/Linux in
amd64_create_target_description, which I agree is a little weird.

I still have an item on my todo list to refactor the x86 target
description creation code, so I've added a note to look at this when I
get to that task (if it's not been addressed earlier), though it'll be
towards the end of this quarter, or Q1 2025 before I'll have time to
look at the target description stuff again I think.

Thanks,
Andrew