From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2OwCBrsDCGerywgAWB0awg (envelope-from ) for ; Thu, 10 Oct 2024 12:41:31 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XkRC44fO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 148BF1E357; Thu, 10 Oct 2024 12:41:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9C4741E05C for ; Thu, 10 Oct 2024 12:41:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3B528385AC1F for ; Thu, 10 Oct 2024 16:41:30 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 33D563858019 for ; Thu, 10 Oct 2024 16:41:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 33D563858019 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 33D563858019 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728578472; cv=none; b=hYeFbR0pctFg1dFbh9S+F2r1MyMC7pRzLT+HR/sLrRzlcyBRJ1nbyyMVblfcxgmFQF1rh3PpYonHEZzbhSDZz52yCtD0WT+UbLPjZsfAy1s5M3ywLhvvlmCzXlFkfAlk1KIJPnscLi3xnlU4UHT1igGjEuXuEf+D+0JLGNODEEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728578472; c=relaxed/simple; bh=HDP0YvggDqyVbXEyn3vzFghTMXDJ9shOz3rAfFEnolM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=b1Vzjq2wU/UbfliZcwoN0H6ugexd45N8ZNvOuIACrCF/pkLO5mB32ZKYir/dnGqkyEtf9TXakUFwkta3amZK6q12UQ8nPBZvV+BMqq+b6kaIHxydHzJz4Z4IyJJ+9KF9FcwCau/VxoRpcZhT33aoqVgT2iFa7XflC9Y1JL/atMs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728578468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yAX2FcszRsGgljq7wqhIKUR6maTUKb5K0qzyz+rYiQw=; b=XkRC44fOlaW6SEm+mSUZifmGhWGuHzg/Io+5BJvc3AK4QY7vHqROaDt6Lvb8ZL78U+p4Nr ae5TrwmgSKflg0RKvmx1eZ8RR9ppr6iz12x/vPyYtOq1+QAN6H0vlWuzlVZUN8qnykitvP +AUQ98uaRvoQN3wCBxUFIsmd9SdgF0o= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-173-ArujuAclP-ueqO8SrtUxiA-1; Thu, 10 Oct 2024 12:41:07 -0400 X-MC-Unique: ArujuAclP-ueqO8SrtUxiA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a7d2d414949so80854566b.0 for ; Thu, 10 Oct 2024 09:41:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728578466; x=1729183266; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yAX2FcszRsGgljq7wqhIKUR6maTUKb5K0qzyz+rYiQw=; b=NS4TRCrYMr9qVdJpGT5EJKkITLLzSiuwNeLTVWGAQBqIvq+zs+dxxL+d6r6rNEQNxA E/WPzKs7o9km30NF7Tz/Cib/C4bS7bmp4ay3JoK9rHQPZ8Z0at3LJ8ZKFwGYU3zpFe+1 rTud8zh1mjIrM52aoDiSNdcLghEOlYbsfsfODgI0MITvt1KUG7AU1Epjx/ES6OOhZWit S8AxDl7U6AXotHTTpU7YdppdeeVVr9q6JInfcNrKeBBdDdi0kJBxbG6Fdp0cJj01L0pj Kb7wjOrSUt4Cq/2AKHqQ0+oxxiMAG4nGXY1ST1JTEKszPDpxF0knRAO9f7agfilEtEXr cQXg== X-Forwarded-Encrypted: i=1; AJvYcCVDMi/vTGzKY2GtJfhhdhCALWL+Nt/oWOjL+64nOC/pxW/tXtTl9EZM+gXjW2XmFBUBfUOY7siRUJnzfw==@sourceware.org X-Gm-Message-State: AOJu0YzS5gI4Ie9eI1ZGHh9ScJzs0Je5OAcmhTuSZ4Z7+1EhCAFb+HIt u0xnzTGoRN1TrFImduRO1eDhkrj8JP/l86ttyKCkgpfwcaWG3FnENquogWlXoIc+yTY4HWwsiJT ap5AFuZTyx7JH3eaBcigtO9eyUfBn+/+BOzpN0b5+HiwBl+RLIl36gzxiDa4= X-Received: by 2002:a17:907:e262:b0:a99:3893:d861 with SMTP id a640c23a62f3a-a998d327a16mr606035566b.50.1728578466238; Thu, 10 Oct 2024 09:41:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJtrC+3awx9gytAElVfm1h9t1SJtH0TAMreOknMC3LuRrEhSYWL5pEh3igUI47gDdcsx8ksA== X-Received: by 2002:a17:907:e262:b0:a99:3893:d861 with SMTP id a640c23a62f3a-a998d327a16mr606033566b.50.1728578465784; Thu, 10 Oct 2024 09:41:05 -0700 (PDT) Received: from localhost ([195.213.152.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99a7f28090sm111074366b.79.2024.10.10.09.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 09:41:05 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Cc: Luis Machado Subject: Re: [PATCH 0/5] Set osabi in remote target descriptions In-Reply-To: <8fdf695d-9bd2-4573-aaf1-72a97a96a21f@simark.ca> References: <8fdf695d-9bd2-4573-aaf1-72a97a96a21f@simark.ca> Date: Thu, 10 Oct 2024 17:41:04 +0100 Message-ID: <87zfnbap27.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > On 2024-10-08 13:11, Andrew Burgess wrote: >> I tried doing some remote debugging of a Window machine from a Linux >> machine and ran into some problems caused by gdbserver failing to set >> the osabi in the target description that is sent to GDB. This series >> fixes this issue. >> >> In v2: >> >> - Patches 3 & 4 are new. These are refactoring to allow for the >> updated patch 5. >> >> - Patch 5 is mostly the same, except the osabi is now set based on >> the enum values, rather than the osabi name strings. >> >> Thanks, >> Andrew > > I'm done sending comments, nothing is a blocker, so feel free to address > them or not, then: > > Approved-By: Simon Marchi I've addressed all the minor issues you raised and pushed this series. I've not addressed the osabi being set to GNU/Linux in amd64_create_target_description, which I agree is a little weird. I still have an item on my todo list to refactor the x86 target description creation code, so I've added a note to look at this when I get to that task (if it's not been addressed earlier), though it'll be towards the end of this quarter, or Q1 2025 before I'll have time to look at the target description stuff again I think. Thanks, Andrew