Re: [PATCH 5/5] gdbserver: pass osabi to GDB in target description

[Andrew Burgess <aburgess@redhat.com>]

Mark Wielaard <mark@klomp.org> writes:

> I am afraid this patch made various buildbot builders on sparc, powerpc,
> and s390x unhappy:
> https://builder.sourceware.org/buildbot/#/changes/63330

Thanks for bringing this up.  I'm going to revert this patch for now
while I work on a solution.

Thanks,
Andrew


>
> The errors all look similar:
>
> reg-sparc64-generated.cc: In function ‘void init_registers_sparc64()’:
> reg-sparc64-generated.cc:215:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’
>   215 |   init_target_desc (result, expedite_regs_sparc64);
>       |   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from reg-sparc64-generated.cc:24:
> ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here
>    86 | void init_target_desc (struct target_desc *tdesc,
>       |      ^~~~~~~~~~~~~~~~
>
> powerpc-32l-generated.cc: In function ‘void init_registers_powerpc_32l()’:
> powerpc-32l-generated.cc:189:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’
>   189 |   init_target_desc (result, expedite_regs_powerpc_32l);
>       |   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from powerpc-32l-generated.cc:24:
> ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here
>    86 | void init_target_desc (struct target_desc *tdesc,
>       |      ^~~~~~~~~~~~~~~~
>
> powerpc-64l-generated.cc: In function ‘void init_registers_powerpc_64l()’:
> powerpc-64l-generated.cc:189:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’
>   189 |   init_target_desc (result, expedite_regs_powerpc_64l);
>       |   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from powerpc-64l-generated.cc:24:
> ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here
>    86 | void init_target_desc (struct target_desc *tdesc,
>       |      ^~~~~~~~~~~~~~~~
>
> s390-gs-linux64-generated.cc: In function ‘void init_registers_s390_gs_linux64()’:
> s390-gs-linux64-generated.cc:299:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’
>   299 |   init_target_desc (result, expedite_regs_s390_gs_linux64);
>       |   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from s390-gs-linux64-generated.cc:24:
> ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here
>    86 | void init_target_desc (struct target_desc *tdesc,
>       |      ^~~~~~~~~~~~~~~~
>
> s390-linux32-generated.cc: In function ‘void init_registers_s390_linux32()’:
> s390-linux32-generated.cc:147:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’
>   147 |   init_target_desc (result, expedite_regs_s390_linux32);
>       |   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from s390-linux32-generated.cc:24:
> ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here
>    86 | void init_target_desc (struct target_desc *tdesc,
>       |      ^~~~~~~~~~~~~~~~