Re: [PATCH 5/5] gdbserver: pass osabi to GDB in target description

[Simon Marchi <simark@simark.ca>]

On 2024-10-08 13:11, Andrew Burgess wrote:
> diff --git a/gdbserver/tdesc.h b/gdbserver/tdesc.h
> index 6fc37d038bc..80d9a9bebcb 100644
> --- a/gdbserver/tdesc.h
> +++ b/gdbserver/tdesc.h
> @@ -81,10 +81,11 @@ void copy_target_description (struct target_desc *dest,
>  			      const struct target_desc *src);
>  
>  /* Initialize TDESC, and then set its expedite_regs field to
> -   EXPEDITE_REGS.  */
> +   EXPEDITE_REGS.  The osabi of TDESC is set to OSABI.  */

To maintain the verb tense and tone, I would write "Set the osabi of
TDESC to OSABI".

Maybe something for a subsequent patch: I find
amd64_create_target_description a little odd.  If you pass is_linux ==
true, the function sets the osabi of the tdesc to linux.  Otherwise, no
osabi is set.  So the resulting tdesc is not consistent for linux vs
other OSes, that can be confusing and error prone.  I think we should
either make it take an osabi parameter, and always set the osabi, or not
make it set the osabi at all (transfer that responsibility to the
callers).

Simon