From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SID8Oj/5B2e9wAgAWB0awg (envelope-from ) for ; Thu, 10 Oct 2024 11:56:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728575807; bh=LyCjrIVpMPQe08sPEoFAeF6YsNxiIXgWs30f40oX9ro=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tWh1qakGbnqf0beY81X2tnqyL9u9pyk2r9MV8NNUK7854GVcdqUdrWsn6AjaWEefc YUPHqAdRkhKXRwA9C9f0ZT8Ce4+jRwXsvIIRbBcZFo7uZrWEz6w42MhxugMklC3ZBQ LPodAQ+z52Kz9dIwzEjg8UjPlvNVkJmccfT9LiBM= Received: by simark.ca (Postfix, from userid 112) id CB08C1E357; Thu, 10 Oct 2024 11:56:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=ehikMCZ/; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=e7xm/pcS; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 39F4B1E355 for ; Thu, 10 Oct 2024 11:56:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6C7B4385AC1A for ; Thu, 10 Oct 2024 15:56:46 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1F208385737F for ; Thu, 10 Oct 2024 15:56:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F208385737F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F208385737F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728575782; cv=none; b=OS9r05y4YAEcRdmzY5SCSP++ht38V1D9J2f5wKgKNQ9aGsjWWZ1hgbmznNdu/EdJoUjiispAYliPAR7UbPldAzgGsm4Z9ZsXLz7vThePm5/KQp6l6//4D5HZIomkabxmZrNLsjvcFEkDv3CAHMmh90DFi1ZSHSBlAPGIgcc6jgQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728575782; c=relaxed/simple; bh=LyCjrIVpMPQe08sPEoFAeF6YsNxiIXgWs30f40oX9ro=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=CFOoCl1h7hwCx2HPv8wjqX8Jp/okBGdzUffYc2kRa5Y3gHOxmPNR3zrWewMTCrTn7DpJTGvTeYDMSfaQBQlpvnZHhGPUgXRZyRM5nx69TbHV4m8n4Oe62z5u/RTq4wv2auqfOjnOXgKFX6L7Ar6jCeS2qZQLIC5+pIYxJnqQjSM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728575780; bh=LyCjrIVpMPQe08sPEoFAeF6YsNxiIXgWs30f40oX9ro=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ehikMCZ/gEpldsv7+apPCnP2unLW+f/Uuoc1vokO1dMvg5gvfm/OcagtM3q7kxLvl qQpm12j0CDco8BxxcEbS9O0RpDBYKMILxIyurz5V0+20u6wuuS3UxQSWTVT9Hwam0p +qvT4rN9/saQB3NN4XBmbYLKm9PlYXIj03h7/DPk= Received: by simark.ca (Postfix, from userid 112) id 975B51E359; Thu, 10 Oct 2024 11:56:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728575778; bh=LyCjrIVpMPQe08sPEoFAeF6YsNxiIXgWs30f40oX9ro=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=e7xm/pcSYxjYYVxxYj11jIKI8L+n4XGuLeEHezu2tuPrQ8zRrgcj0oMS6HlOqvRkU w8lE+JjyGaBJNmRdQafr/Ea7pwal4vrLUWjyL6lYJGP8VizBBNOHAmnTrKzPAZz7u7 Iv6HOZ9qDz2Ycfc7EjOwoNBDop84l68gOay7ovZU= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 582941E355; Thu, 10 Oct 2024 11:56:18 -0400 (EDT) Message-ID: <1658c7bc-c410-48c5-9847-256b238179f4@simark.ca> Date: Thu, 10 Oct 2024 11:56:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] gdbserver: pass osabi to GDB in target description To: Andrew Burgess , gdb-patches@sourceware.org Cc: Luis Machado References: <77fa25e6f6fd213f89ebceb7c1fcf33010cc8e39.1728407374.git.aburgess@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <77fa25e6f6fd213f89ebceb7c1fcf33010cc8e39.1728407374.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2024-10-08 13:11, Andrew Burgess wrote: > diff --git a/gdbserver/tdesc.h b/gdbserver/tdesc.h > index 6fc37d038bc..80d9a9bebcb 100644 > --- a/gdbserver/tdesc.h > +++ b/gdbserver/tdesc.h > @@ -81,10 +81,11 @@ void copy_target_description (struct target_desc *dest, > const struct target_desc *src); > > /* Initialize TDESC, and then set its expedite_regs field to > - EXPEDITE_REGS. */ > + EXPEDITE_REGS. The osabi of TDESC is set to OSABI. */ To maintain the verb tense and tone, I would write "Set the osabi of TDESC to OSABI". Maybe something for a subsequent patch: I find amd64_create_target_description a little odd. If you pass is_linux == true, the function sets the osabi of the tdesc to linux. Otherwise, no osabi is set. So the resulting tdesc is not consistent for linux vs other OSes, that can be confusing and error prone. I think we should either make it take an osabi parameter, and always set the osabi, or not make it set the osabi at all (transfer that responsibility to the callers). Simon