Re: [PATCH 2/3] gdb: make use of set_tdesc_osabi overload in features/ files

[Simon Marchi <simark@simark.ca>]

On 2024-10-06 14:37, Andrew Burgess wrote:
> There are two versions of the set_tdesc_osabi function in GDB:
> 
>   void
>   set_tdesc_osabi (struct target_desc *target_desc, const char *name)
>   {
>     set_tdesc_osabi (target_desc, osabi_from_tdesc_string (name));
>   }
> 
>   void
>   set_tdesc_osabi (struct target_desc *target_desc, enum gdb_osabi osabi)
>   {
>     target_desc->osabi = osabi;
>   }
> 
> In the gdb/features/ files we call the second of these functions, like
> this:
> 
>   set_tdesc_osabi (result.get (), osabi_from_tdesc_string ("GNU/Linux"));
> 
> This can be replaced with a call to the first set_tdesc_osabi
> function, so lets do that.  I think that this makes the features/ code
> slightly simpler and easier to understand.
> 
> There should be no user visible changes after this commit.

Just a nit but... while at it, couldn't we change them to use the
enumerator directly, to save lookups at runtime?

   set_tdesc_osabi (result.get (), GDB_OSABI_LINUX);

I guess we would need a enum -> string (GDB_OSABI_LINUX ->
"GDB_OSABI_LINUX") function, which we have for other enums.  We just
don't have it for this enum yet.  Another case for adding a "magic enum"
library :).

Simon