From: Mark Wielaard <mark@klomp.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, Luis Machado <luis.machado@arm.com>
Subject: Re: [PATCH 5/5] gdbserver: pass osabi to GDB in target description
Date: Thu, 10 Oct 2024 22:19:15 +0200 [thread overview]
Message-ID: <3eba1004-cf3d-4cb4-9c2d-f8e6b194ce6b@wildebeest.org> (raw)
In-Reply-To: <77fa25e6f6fd213f89ebceb7c1fcf33010cc8e39.1728407374.git.aburgess@redhat.com>
I am afraid this patch made various buildbot builders on sparc, powerpc,
and s390x unhappy:
https://builder.sourceware.org/buildbot/#/changes/63330
The errors all look similar:
reg-sparc64-generated.cc: In function ‘void init_registers_sparc64()’:
reg-sparc64-generated.cc:215:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’
215 | init_target_desc (result, expedite_regs_sparc64);
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from reg-sparc64-generated.cc:24:
../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here
86 | void init_target_desc (struct target_desc *tdesc,
| ^~~~~~~~~~~~~~~~
powerpc-32l-generated.cc: In function ‘void init_registers_powerpc_32l()’:
powerpc-32l-generated.cc:189:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’
189 | init_target_desc (result, expedite_regs_powerpc_32l);
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from powerpc-32l-generated.cc:24:
../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here
86 | void init_target_desc (struct target_desc *tdesc,
| ^~~~~~~~~~~~~~~~
powerpc-64l-generated.cc: In function ‘void init_registers_powerpc_64l()’:
powerpc-64l-generated.cc:189:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’
189 | init_target_desc (result, expedite_regs_powerpc_64l);
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from powerpc-64l-generated.cc:24:
../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here
86 | void init_target_desc (struct target_desc *tdesc,
| ^~~~~~~~~~~~~~~~
s390-gs-linux64-generated.cc: In function ‘void init_registers_s390_gs_linux64()’:
s390-gs-linux64-generated.cc:299:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’
299 | init_target_desc (result, expedite_regs_s390_gs_linux64);
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from s390-gs-linux64-generated.cc:24:
../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here
86 | void init_target_desc (struct target_desc *tdesc,
| ^~~~~~~~~~~~~~~~
s390-linux32-generated.cc: In function ‘void init_registers_s390_linux32()’:
s390-linux32-generated.cc:147:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’
147 | init_target_desc (result, expedite_regs_s390_linux32);
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from s390-linux32-generated.cc:24:
../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here
86 | void init_target_desc (struct target_desc *tdesc,
| ^~~~~~~~~~~~~~~~
next prev parent reply other threads:[~2024-10-10 20:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 18:37 [PATCH 0/3] Set osabi in remote target descriptions Andrew Burgess
2024-10-06 18:37 ` [PATCH 1/3] gdbserver: make arch and osabi names gdb::unique_xmalloc_ptr<char> Andrew Burgess
2024-10-07 17:00 ` Tom Tromey
2024-10-08 19:02 ` Simon Marchi
2024-10-09 11:07 ` Andrew Burgess
2024-10-09 11:45 ` Simon Marchi
2024-10-09 12:17 ` Andrew Burgess
2024-10-09 15:35 ` Simon Marchi
2024-10-09 15:50 ` Andrew Burgess
2024-10-06 18:37 ` [PATCH 2/3] gdb: make use of set_tdesc_osabi overload in features/ files Andrew Burgess
2024-10-07 17:00 ` Tom Tromey
2024-10-08 19:12 ` Simon Marchi
2024-10-09 11:08 ` Andrew Burgess
2024-10-09 11:48 ` Simon Marchi
2024-10-09 12:04 ` Andrew Burgess
2024-10-06 18:37 ` [PATCH 3/3] gdbserver: pass osabi to GDB in target description Andrew Burgess
2024-10-07 9:38 ` Luis Machado
2024-10-07 17:00 ` Tom Tromey
2024-10-08 17:11 ` [PATCH 0/5] Set osabi in remote target descriptions Andrew Burgess
2024-10-08 17:11 ` [PATCH 1/5] gdbserver: make arch and osabi names gdb::unique_xmalloc_ptr<char> Andrew Burgess
2024-10-10 13:37 ` Simon Marchi
2024-10-10 15:31 ` Andrew Burgess
2024-10-08 17:11 ` [PATCH 2/5] gdb: make use of set_tdesc_osabi overload in features/ files Andrew Burgess
2024-10-08 17:11 ` [PATCH 3/5] gdb: split osabi support between gdb/ and gdbsupport/ directories Andrew Burgess
2024-10-09 7:12 ` Luis Machado
2024-10-10 13:47 ` Simon Marchi
2024-10-08 17:11 ` [PATCH 4/5] gdb/gdbserver: change shared set_tdesc_osabi to take gdb_osabi Andrew Burgess
2024-10-09 7:12 ` Luis Machado
2024-10-10 15:23 ` Simon Marchi
2024-10-08 17:11 ` [PATCH 5/5] gdbserver: pass osabi to GDB in target description Andrew Burgess
2024-10-09 7:14 ` Luis Machado
2024-10-10 15:56 ` Simon Marchi
2024-10-10 20:19 ` Mark Wielaard [this message]
2024-10-11 8:31 ` Andrew Burgess
2024-10-10 15:57 ` [PATCH 0/5] Set osabi in remote target descriptions Simon Marchi
2024-10-10 16:41 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eba1004-cf3d-4cb4-9c2d-f8e6b194ce6b@wildebeest.org \
--to=mark@klomp.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox