From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4JMUJ9g2CGcA9wgAWB0awg (envelope-from ) for ; Thu, 10 Oct 2024 16:19:36 -0400 Received: by simark.ca (Postfix, from userid 112) id 9B3471E357; Thu, 10 Oct 2024 16:19:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.7 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED, URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B8E041E05C for ; Thu, 10 Oct 2024 16:19:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 533DB3858283 for ; Thu, 10 Oct 2024 20:19:35 +0000 (GMT) Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 8C1273857C6C for ; Thu, 10 Oct 2024 20:19:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C1273857C6C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8C1273857C6C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728591559; cv=none; b=ZzgPG3PXccNE1sG1zs3uIchXVxtBH7NDm/PoYVrA3fg+tetoxRLVPpYa2DBaEM/Ar8JZMPzFKM/Ely5AV+CflgjRUogr/onEphNXHYkg2pfNW0Ah+xxK3lxNxewxxRe02enI/sbOkGNUlZ3nRB42NNuhwwpv2BWPWW8gSb4N/Ic= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728591559; c=relaxed/simple; bh=iPx3+utLu+tabApwXTJYajJroWJit6k7jAYt38bPg9k=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=Ahkc7s689ni8lHv/r8m2HtnbtAL3p8pY3WycZiqOW27hUB6Y6ZrMvRmqyLuZeW6XlaqXkArWpI3lH+5G1OduXRga+axLVCCRZow6PUpu64zramjnD/1jvuI3vf3jRcnp+UqDgFW+8JE14lKrIychOCDyvecfaIZIRBoLywN2GBA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mwielaar-thinkpadp1gen3.rmtnl.csb (deer0x08.wildebeest.org [172.31.17.138]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id A807630D0628; Thu, 10 Oct 2024 22:19:15 +0200 (CEST) Received: by mwielaar-thinkpadp1gen3.rmtnl.csb (Postfix, from userid 10916) id 620BB58B41F; Thu, 10 Oct 2024 22:19:15 +0200 (CEST) Date: Thu, 10 Oct 2024 22:19:15 +0200 From: Mark Wielaard To: Andrew Burgess Cc: gdb-patches@sourceware.org, Luis Machado Subject: Re: [PATCH 5/5] gdbserver: pass osabi to GDB in target description Message-ID: <3eba1004-cf3d-4cb4-9c2d-f8e6b194ce6b@wildebeest.org> References: <77fa25e6f6fd213f89ebceb7c1fcf33010cc8e39.1728407374.git.aburgess@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <77fa25e6f6fd213f89ebceb7c1fcf33010cc8e39.1728407374.git.aburgess@redhat.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I am afraid this patch made various buildbot builders on sparc, powerpc, and s390x unhappy: https://builder.sourceware.org/buildbot/#/changes/63330 The errors all look similar: reg-sparc64-generated.cc: In function ‘void init_registers_sparc64()’: reg-sparc64-generated.cc:215:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’ 215 | init_target_desc (result, expedite_regs_sparc64); | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from reg-sparc64-generated.cc:24: ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here 86 | void init_target_desc (struct target_desc *tdesc, | ^~~~~~~~~~~~~~~~ powerpc-32l-generated.cc: In function ‘void init_registers_powerpc_32l()’: powerpc-32l-generated.cc:189:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’ 189 | init_target_desc (result, expedite_regs_powerpc_32l); | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from powerpc-32l-generated.cc:24: ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here 86 | void init_target_desc (struct target_desc *tdesc, | ^~~~~~~~~~~~~~~~ powerpc-64l-generated.cc: In function ‘void init_registers_powerpc_64l()’: powerpc-64l-generated.cc:189:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’ 189 | init_target_desc (result, expedite_regs_powerpc_64l); | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from powerpc-64l-generated.cc:24: ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here 86 | void init_target_desc (struct target_desc *tdesc, | ^~~~~~~~~~~~~~~~ s390-gs-linux64-generated.cc: In function ‘void init_registers_s390_gs_linux64()’: s390-gs-linux64-generated.cc:299:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’ 299 | init_target_desc (result, expedite_regs_s390_gs_linux64); | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from s390-gs-linux64-generated.cc:24: ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here 86 | void init_target_desc (struct target_desc *tdesc, | ^~~~~~~~~~~~~~~~ s390-linux32-generated.cc: In function ‘void init_registers_s390_linux32()’: s390-linux32-generated.cc:147:20: error: too few arguments to function ‘void init_target_desc(target_desc*, const char**, gdb_osabi)’ 147 | init_target_desc (result, expedite_regs_s390_linux32); | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from s390-linux32-generated.cc:24: ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here 86 | void init_target_desc (struct target_desc *tdesc, | ^~~~~~~~~~~~~~~~