From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yIZZGYHiCGcomwkAWB0awg (envelope-from ) for ; Fri, 11 Oct 2024 04:32:01 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RRO7E96w; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 460941E357; Fri, 11 Oct 2024 04:32:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 680AE1E0C0 for ; Fri, 11 Oct 2024 04:32:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F315A3857B84 for ; Fri, 11 Oct 2024 08:31:59 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id D463B3857BA9 for ; Fri, 11 Oct 2024 08:31:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D463B3857BA9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D463B3857BA9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728635501; cv=none; b=I1cy+3+UO2DZbAFAFxzk9G26eU5yUBTPYhhhQhHPJt7JaLkRpwtbwOc4d8pOvVyigebQTSnKK6xmj5/9973sl3OBvvPEg42SZYmmb6ln53qbWQB1+JLCOtVnMwvYyGdaflov+HqS8dy3AYsdleBbrkVaE19fnvxtBvwfF/OgO3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728635501; c=relaxed/simple; bh=RYq9vKTM/zCK1Vp0LPTXioH1Ek5kvLLXNJzDuO6SK9k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iAyRYJdBVzglq/zXgQhmTPFIxuFK7p7Zb0LU1t3UguEpjv1YiamNQVpXxTBH8I4gOgie/by9R4fPkBxAtFTmhn88rTgYoeVZMAUC6hJGW5F+dj0pMOw6NuzlbOMfAMRvsbuATlDhT4B7/oyZI+g3hbBSPDLffmBbXK7enih6nPE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728635499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5C7RA0pZljvWz+A/YwBagCl6yyiAU6AqpCOTcqmd2L8=; b=RRO7E96wuPVowVxgW+c9EpTYEou13hiK+o45WT9cE5SvQn7MhDdz0E2f3C2Ty8nvY59v/t zaUhnSiAXFOFu8txLB+4lEwli3nGiThYBRSncnocab9d7nXXAH1ejh/dh1KnhGU7tegBmn 8x2UDUGLmfDNO9+PBqrbOd1QYcbMd7Y= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-dJtoWO9CPOi7tWQLPVrjfA-1; Fri, 11 Oct 2024 04:31:38 -0400 X-MC-Unique: dJtoWO9CPOi7tWQLPVrjfA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d43e7acd9so772708f8f.2 for ; Fri, 11 Oct 2024 01:31:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728635497; x=1729240297; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5C7RA0pZljvWz+A/YwBagCl6yyiAU6AqpCOTcqmd2L8=; b=gnCqdjwb5HEr11jDpSyjdK7gNr4m2Ay4jFXgzprOVIUPe+PsseA0JkenWdlgBUxI8p Wx+C4CI/FHp4tS+VqDgmfEWNfN/XsE+Wi2DXrrBnfjRNcEwgA8Cl7f1P42/8mON3hvdL mti60bK16USSurgKExPVdQJXYo2SPDhJ4JWbRsNvImVApA7RwulSz1OO2uUbhbDgHdc7 CApnI8D28AqZPPTfY0Z1T5HZWQ1x7zNm/+MGO2NJ0uuP124KtzuW4Izfk4m3l/XiEjyy 59GXjyCGvx4e5LF1fQhXQozsDFdbfsKylTvoGDFx7OzRP89j4jWIaBn8BNEvZNEb4t9U GuOw== X-Gm-Message-State: AOJu0YyN1Jt60/PM+ztvRz3YOUy9rd65ss0RkNB2aGvaMunMeOQjqJLd rAuAYKOaU1GWrRpPrPFUeYrmvHV4PBZRPmhQccSnsFPl6qmMMhF4kK4HRL9oGsy9ln8utl6xTR4 +jdvN6iZrZym0VSI+daaCrg5FTu48SjgGsV4Rw7uHL3bsvdHgGftStSl942w= X-Received: by 2002:a5d:404d:0:b0:37d:4f1b:35b with SMTP id ffacd0b85a97d-37d551fb778mr1143302f8f.34.1728635496778; Fri, 11 Oct 2024 01:31:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF+b+CKiK/5kipvhI8VnEskcmHKN+QtRCdri++S4O8HkVI6AL55I2h7LzjUbqCXKlPWZqJnMg== X-Received: by 2002:a5d:404d:0:b0:37d:4f1b:35b with SMTP id ffacd0b85a97d-37d551fb778mr1143282f8f.34.1728635496316; Fri, 11 Oct 2024 01:31:36 -0700 (PDT) Received: from localhost ([195.213.152.26]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b7ee48fsm3375843f8f.96.2024.10.11.01.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 01:31:35 -0700 (PDT) From: Andrew Burgess To: Mark Wielaard Cc: gdb-patches@sourceware.org, Luis Machado Subject: Re: [PATCH 5/5] gdbserver: pass osabi to GDB in target description In-Reply-To: <3eba1004-cf3d-4cb4-9c2d-f8e6b194ce6b@wildebeest.org> References: <77fa25e6f6fd213f89ebceb7c1fcf33010cc8e39.1728407374.git.aburgess@redhat.com> <3eba1004-cf3d-4cb4-9c2d-f8e6b194ce6b@wildebeest.org> Date: Fri, 11 Oct 2024 09:31:34 +0100 Message-ID: <87wmif9h21.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Mark Wielaard writes: > I am afraid this patch made various buildbot builders on sparc, powerpc, > and s390x unhappy: > https://builder.sourceware.org/buildbot/#/changes/63330 Thanks for bringing this up. I'm going to revert this patch for now while I work on a solution. Thanks, Andrew > > The errors all look similar: > > reg-sparc64-generated.cc: In function =E2=80=98void init_registers_sparc6= 4()=E2=80=99: > reg-sparc64-generated.cc:215:20: error: too few arguments to function =E2= =80=98void init_target_desc(target_desc*, const char**, gdb_osabi)=E2=80=99 > 215 | init_target_desc (result, expedite_regs_sparc64); > | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from reg-sparc64-generated.cc:24: > ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here > 86 | void init_target_desc (struct target_desc *tdesc, > | ^~~~~~~~~~~~~~~~ > > powerpc-32l-generated.cc: In function =E2=80=98void init_registers_powerp= c_32l()=E2=80=99: > powerpc-32l-generated.cc:189:20: error: too few arguments to function =E2= =80=98void init_target_desc(target_desc*, const char**, gdb_osabi)=E2=80=99 > 189 | init_target_desc (result, expedite_regs_powerpc_32l); > | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from powerpc-32l-generated.cc:24: > ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here > 86 | void init_target_desc (struct target_desc *tdesc, > | ^~~~~~~~~~~~~~~~ > > powerpc-64l-generated.cc: In function =E2=80=98void init_registers_powerp= c_64l()=E2=80=99: > powerpc-64l-generated.cc:189:20: error: too few arguments to function =E2= =80=98void init_target_desc(target_desc*, const char**, gdb_osabi)=E2=80=99 > 189 | init_target_desc (result, expedite_regs_powerpc_64l); > | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from powerpc-64l-generated.cc:24: > ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here > 86 | void init_target_desc (struct target_desc *tdesc, > | ^~~~~~~~~~~~~~~~ > > s390-gs-linux64-generated.cc: In function =E2=80=98void init_registers_s3= 90_gs_linux64()=E2=80=99: > s390-gs-linux64-generated.cc:299:20: error: too few arguments to function= =E2=80=98void init_target_desc(target_desc*, const char**, gdb_osabi)=E2= =80=99 > 299 | init_target_desc (result, expedite_regs_s390_gs_linux64); > | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from s390-gs-linux64-generated.cc:24: > ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here > 86 | void init_target_desc (struct target_desc *tdesc, > | ^~~~~~~~~~~~~~~~ > > s390-linux32-generated.cc: In function =E2=80=98void init_registers_s390_= linux32()=E2=80=99: > s390-linux32-generated.cc:147:20: error: too few arguments to function = =E2=80=98void init_target_desc(target_desc*, const char**, gdb_osabi)=E2=80= =99 > 147 | init_target_desc (result, expedite_regs_s390_linux32); > | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from s390-linux32-generated.cc:24: > ../../binutils-gdb/gdbserver/tdesc.h:86:6: note: declared here > 86 | void init_target_desc (struct target_desc *tdesc, > | ^~~~~~~~~~~~~~~~