[SH] regs command

[Thomas Schwinge <thomas@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]

Hi!

There are issues with sh-tdep's regs command (»Print all registers«):

    (gdb) regs
          PC 295568c0       SR 00008000       PR 00000000     MACH 00000000
    Register 19 is not available

(After PC, SR, PR, MACH, this should print the values of the GBR, VBR
(this is register 19), MACL, then R0..R15.)  Evidently this code is not
prepared to cope with frame_unwind_register raising NOT_AVAILABLE_ERROR.

Now, the question is, why does the regs command exist at all?  It's been
present since the very first revision of sh-tdep.c, but as far as I can
tell, »info registers«/»info all-registers« can display all the register
information just fine, for example:

    (gdb) info all-registers
    r0             0x0      0
    [...]
    r15            0x7bab5c60       2074827872
    pc             0x295568c0       693463232
    pr             0x0      0
    gbr            0x29690678       694748792
    vbr            *value not available*
    mach           0x0      0
    macl           0x0      0
    sr             0x8000   32768

I therefore propose to remove sh_show_regs_command et al. from sh-tdep.c.
If nobody objects, can it just go silently, or should invoking it then
cause an error message, like »Please use the »info all-registers« command
instead of »regs«.«?


Grüße,
 Thomas

[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]