Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: "Maciej W. Rozycki" <macro@codesourcery.com>,
	Tom Tromey <tromey@redhat.com>,
	Mark Kettenis <mark.kettenis@xs4all.nl>,
	thomas@codesourcery.com,	gdb-patches@sourceware.org,
	kevinb@redhat.com
Subject: Re: [SH] regs command
Date: Fri, 18 May 2012 12:49:00 -0000	[thread overview]
Message-ID: <20120518124843.GK10253@adacore.com> (raw)
In-Reply-To: <4FB642E4.6050106@redhat.com>

> >   /* Initialize this lazily, to avoid an initialization order
> >      dependency on solib-svr4.c's _initialize routine.  */
> >   if (mips_svr4_so_ops.in_dynsym_resolve_code == NULL)
> >     {
> >       mips_svr4_so_ops = svr4_so_ops;
> >       mips_svr4_so_ops.in_dynsym_resolve_code
> >         = mips_linux_in_dynsym_resolve_code;
> >     }
> >   set_solib_ops (gdbarch, &mips_svr4_so_ops);
> solib-svr4.c is as much target dependent as mips-linux-tdep.c though.
> The split on file name is a bit arbitrary.  It'd make a bit more sense
> to split around something like COMMON_OBS and TARGET_OBJS, but you'd
> still bump into such issues.  A "don't depend on order" rule appears
> simpler to understand and maintain than having to worry about
> hierarchies.

And I *think* we solved that problem elsewhere, right? Basically,
we call functions to get the ops vector. That way, no matter the
init order, we always access initialized data... See the inf-*
files IIRC.

-- 
Joel


  reply	other threads:[~2012-05-18 12:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16 13:56 Thomas Schwinge
2012-05-16 14:26 ` Joel Brobecker
2012-05-16 16:32   ` Thomas Schwinge
2012-05-16 16:58     ` Joel Brobecker
2012-05-16 17:21       ` Thomas Schwinge
2012-05-16 18:47         ` Tom Tromey
2012-05-16 19:06           ` Joel Brobecker
2012-05-16 19:38             ` Maciej W. Rozycki
2012-05-17  0:59               ` Maciej W. Rozycki
2012-05-17 11:10                 ` Mark Kettenis
2012-05-17 11:23                   ` Maciej W. Rozycki
2012-05-17 12:38                     ` Joel Brobecker
2012-05-17 15:23                       ` Mark Kettenis
2012-05-17 15:45                         ` Joel Brobecker
2012-05-17 19:52                           ` Tom Tromey
2012-05-17 20:38                             ` Joel Brobecker
2012-05-18 12:23                               ` Maciej W. Rozycki
2012-05-18 12:39                                 ` Pedro Alves
2012-05-18 12:49                                   ` Joel Brobecker [this message]
2012-05-18 13:33                                     ` Pedro Alves
2012-05-18 13:47                                 ` Tom Tromey
2012-05-21 23:36                                   ` Maciej W. Rozycki
2012-05-24 18:05                                     ` Tom Tromey
2012-05-17 19:32         ` Kevin Buettner
2012-05-16 18:36       ` Tom Tromey
2012-05-16 18:36     ` Pedro Alves
2012-05-16 19:36     ` Eli Zaretskii
2012-06-06 18:10     ` Thomas Schwinge
2012-08-10  9:22       ` Thomas Schwinge
2012-08-10 16:20         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120518124843.GK10253@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=macro@codesourcery.com \
    --cc=mark.kettenis@xs4all.nl \
    --cc=palves@redhat.com \
    --cc=thomas@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox