From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: macro@codesourcery.com
Cc: brobecker@adacore.com, thomas@codesourcery.com,
tromey@redhat.com, gdb-patches@sourceware.org,
kevinb@redhat.com
Subject: Re: [SH] regs command
Date: Thu, 17 May 2012 11:10:00 -0000 [thread overview]
Message-ID: <201205171109.q4HB9Ljc005742@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <alpine.DEB.1.10.1205170145070.11227@tp.orcam.me.uk> (macro@codesourcery.com)
> Date: Thu, 17 May 2012 01:59:29 +0100
> From: "Maciej W. Rozycki" <macro@codesourcery.com>
>
> On Wed, 16 May 2012, Maciej W. Rozycki wrote:
>
> > > > This means you registered "regs" before the thing it aliases was
> > > > registered. This can happen because _initialize_xxx order is not
> > > > defined.
> > > >
> > > > There's no easy fix :(. You could move "regs" initialization to a
> > > > better spot but then it will be visible in all builds of gdb, not just
> > > > those with this target compiled in.
> > >
> > > It seems better in that case to just go with what Thomas had initially,
> > > maybe just adding a comment why we don't use an alias? It's only for
> > > a few weeks...
> >
> > I think a fix is actually very easy. All that has to be done is to tweak
> > the init.c scriptery such that *_tdep initialisers are run last. And
> > actually I think it is worth the while regardless of this particular issue
> > as this way all the target-dependent bits can rely on generic stuff to
> > have been initialised.
> >
> > Of course tweaking the scriptery can be horribly boring, but there you
> > go. I'll see if I can give it a shot -- unless anyone beats me to it.
>
> So here it is, this change moves *_tdep initialisers to the end while
> otherwise keeping the order the same (IOW within the two groups the order
> remains the same as before). I've checked it against autoconf's tool
> portability list and also verified it with Solaris sed to make sure
> there are no surprises.
Sorry, but we've always considered it a mistake to rely on a specific
order of running the initialization functions. Implicit dependencies
between modules like that really are a bad idea.
next prev parent reply other threads:[~2012-05-17 11:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 13:56 Thomas Schwinge
2012-05-16 14:26 ` Joel Brobecker
2012-05-16 16:32 ` Thomas Schwinge
2012-05-16 16:58 ` Joel Brobecker
2012-05-16 17:21 ` Thomas Schwinge
2012-05-16 18:47 ` Tom Tromey
2012-05-16 19:06 ` Joel Brobecker
2012-05-16 19:38 ` Maciej W. Rozycki
2012-05-17 0:59 ` Maciej W. Rozycki
2012-05-17 11:10 ` Mark Kettenis [this message]
2012-05-17 11:23 ` Maciej W. Rozycki
2012-05-17 12:38 ` Joel Brobecker
2012-05-17 15:23 ` Mark Kettenis
2012-05-17 15:45 ` Joel Brobecker
2012-05-17 19:52 ` Tom Tromey
2012-05-17 20:38 ` Joel Brobecker
2012-05-18 12:23 ` Maciej W. Rozycki
2012-05-18 12:39 ` Pedro Alves
2012-05-18 12:49 ` Joel Brobecker
2012-05-18 13:33 ` Pedro Alves
2012-05-18 13:47 ` Tom Tromey
2012-05-21 23:36 ` Maciej W. Rozycki
2012-05-24 18:05 ` Tom Tromey
2012-05-17 19:32 ` Kevin Buettner
2012-05-16 18:36 ` Tom Tromey
2012-05-16 18:36 ` Pedro Alves
2012-05-16 19:36 ` Eli Zaretskii
2012-06-06 18:10 ` Thomas Schwinge
2012-08-10 9:22 ` Thomas Schwinge
2012-08-10 16:20 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205171109.q4HB9Ljc005742@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=macro@codesourcery.com \
--cc=thomas@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox