Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] Add $_ada_exception convenience variable
Date: Fri, 28 Jun 2019 18:46:00 -0000	[thread overview]
Message-ID: <878stly2dy.fsf@tromey.com> (raw)
In-Reply-To: <83r27fhqxo.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Jun	2019 20:35:31 +0300")

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

>> +The convenience variable @code{$_ada_exception} holds the address of
>> +the exception being thrown.  This can be useful when setting a
>> +condition for such a catchpoint.

Eli> Here I wonder why we need to have the exact same text 3 times within
Eli> less than 25 lines.  Can't we say this only once?

The reason I repeated it is that this section is pretty big -- all the
catchpoints are documented in a single large table.

I could split this up somehow.  Maybe sub-nodes?

Or, I could mention it in the first Ada catchpoint documentation and
then have the other ones refer back to that.

What would you prefer?

Tom


  reply	other threads:[~2019-06-28 18:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 14:52 [PATCH 0/4] Handle copy relocations and add $_ada_exception Tom Tromey
2019-06-27 14:52 ` [PATCH 1/4] Change SYMBOL_VALUE_ADDRESS to be an lvalue Tom Tromey
2019-07-20 23:17   ` Simon Marchi
2019-07-23 15:53     ` Tom Tromey
2019-06-27 14:52 ` [PATCH 2/4] Handle copy relocations Tom Tromey
2019-07-20  1:11   ` Pedro Alves
2019-07-30 21:00     ` Tom Tromey
2019-07-30 21:28       ` Tom Tromey
2019-07-31 19:21         ` Tom Tromey
2019-06-27 14:52 ` [PATCH 3/4] Back out earlier Ada exception change Tom Tromey
2019-06-27 15:02 ` [PATCH 4/4] Add $_ada_exception convenience variable Tom Tromey
2019-06-27 17:35   ` Eli Zaretskii
2019-06-28 18:46     ` Tom Tromey [this message]
2019-06-28 19:43       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878stly2dy.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox