From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62435 invoked by alias); 28 Jun 2019 18:46:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62160 invoked by uid 89); 28 Jun 2019 18:46:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:733, catchpoints, $_ada_exception, _ada_exception X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Jun 2019 18:46:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 57A1D560D4; Fri, 28 Jun 2019 14:46:02 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id A9Y+1LjwuAXD; Fri, 28 Jun 2019 14:46:02 -0400 (EDT) Received: from murgatroyd (75-166-12-78.hlrn.qwest.net [75.166.12.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id D30B4560D2; Fri, 28 Jun 2019 14:46:01 -0400 (EDT) From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] Add $_ada_exception convenience variable References: <20190627145235.21222-1-tromey@adacore.com> <20190627145235.21222-5-tromey@adacore.com> <83r27fhqxo.fsf@gnu.org> Date: Fri, 28 Jun 2019 18:46:00 -0000 In-Reply-To: <83r27fhqxo.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Jun 2019 20:35:31 +0300") Message-ID: <878stly2dy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00638.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: >> +The convenience variable @code{$_ada_exception} holds the address of >> +the exception being thrown. This can be useful when setting a >> +condition for such a catchpoint. Eli> Here I wonder why we need to have the exact same text 3 times within Eli> less than 25 lines. Can't we say this only once? The reason I repeated it is that this section is pretty big -- all the catchpoints are documented in a single large table. I could split this up somehow. Maybe sub-nodes? Or, I could mention it in the first Ada catchpoint documentation and then have the other ones refer back to that. What would you prefer? Tom