Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: Pedro Alves <palves@redhat.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Handle copy relocations
Date: Wed, 31 Jul 2019 19:21:00 -0000	[thread overview]
Message-ID: <87a7cuhuwj.fsf@tromey.com> (raw)
In-Reply-To: <877e7zky9c.fsf@tromey.com> (Tom Tromey's message of "Tue, 30 Jul	2019 15:28:47 -0600")

Tom> Digging a bit deeper, the culprit seems to be lookup_global_symbol.
Tom> I think this function should respect a block that's passed in.

I managed to get the new test completely passing.

I changed basic_lookup_symbol_nonlocal to search the block's global
block, and I removed the long comments fro 2002-3 about why this isn't
done.  TBH I think all of that was just mistaken.

This change got to just 2 failures.  The last two were both the
"hidden0...main0" variants, which print:

get_version_1: &this_version_id=0x7ffff7fca010, this_version_id=104
get_version_2: &this_version_id=0x7ffff7fca010, this_version_id=104

So, I think for these the answer is to change the new get_symbol_address
to search all objfiles in order.  I'm slightly unhappy with this but it
seems correct enough.

I'm re-testing the series and will resubmit it once that's done,
assuming there aren't regressions.

thanks,
Tom


  reply	other threads:[~2019-07-31 19:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 14:52 [PATCH 0/4] Handle copy relocations and add $_ada_exception Tom Tromey
2019-06-27 14:52 ` [PATCH 3/4] Back out earlier Ada exception change Tom Tromey
2019-06-27 14:52 ` [PATCH 1/4] Change SYMBOL_VALUE_ADDRESS to be an lvalue Tom Tromey
2019-07-20 23:17   ` Simon Marchi
2019-07-23 15:53     ` Tom Tromey
2019-06-27 14:52 ` [PATCH 2/4] Handle copy relocations Tom Tromey
2019-07-20  1:11   ` Pedro Alves
2019-07-30 21:00     ` Tom Tromey
2019-07-30 21:28       ` Tom Tromey
2019-07-31 19:21         ` Tom Tromey [this message]
2019-06-27 15:02 ` [PATCH 4/4] Add $_ada_exception convenience variable Tom Tromey
2019-06-27 17:35   ` Eli Zaretskii
2019-06-28 18:46     ` Tom Tromey
2019-06-28 19:43       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7cuhuwj.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox