From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Handle copy relocations
Date: Tue, 30 Jul 2019 21:28:00 -0000 [thread overview]
Message-ID: <877e7zky9c.fsf@tromey.com> (raw)
In-Reply-To: <87d0hrkzl3.fsf@tromey.com> (Tom Tromey's message of "Tue, 30 Jul 2019 15:00:08 -0600")
Tom> I haven't investigated the other failures yet, but I think this one in
Tom> particular is an existing bug in c-exp.y. What happens is that this
Tom> does not actually look up the symbol from that source file! Instead it
Tom> finds the symbol in print-file-var-lib1.c.
Digging a bit deeper, the culprit seems to be lookup_global_symbol.
I think this function should respect a block that's passed in.
However, this code also calls
gdbarch_iterate_over_objfiles_in_search_order and solib_global_lookup,
and now I wonder if one or both of these needs to be changed
as well.
For example, if stopped in the library, "print this_version_id" should
probably follow the expected-by-the-library-author lookup, but currently
I think will not.
Maybe windows_iterate_over_objfiles_in_search_order should just be the
default. I am not sure.
Tom
next prev parent reply other threads:[~2019-07-30 21:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 14:52 [PATCH 0/4] Handle copy relocations and add $_ada_exception Tom Tromey
2019-06-27 14:52 ` [PATCH 1/4] Change SYMBOL_VALUE_ADDRESS to be an lvalue Tom Tromey
2019-07-20 23:17 ` Simon Marchi
2019-07-23 15:53 ` Tom Tromey
2019-06-27 14:52 ` [PATCH 2/4] Handle copy relocations Tom Tromey
2019-07-20 1:11 ` Pedro Alves
2019-07-30 21:00 ` Tom Tromey
2019-07-30 21:28 ` Tom Tromey [this message]
2019-07-31 19:21 ` Tom Tromey
2019-06-27 14:52 ` [PATCH 3/4] Back out earlier Ada exception change Tom Tromey
2019-06-27 15:02 ` [PATCH 4/4] Add $_ada_exception convenience variable Tom Tromey
2019-06-27 17:35 ` Eli Zaretskii
2019-06-28 18:46 ` Tom Tromey
2019-06-28 19:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e7zky9c.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox