From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] Change SYMBOL_VALUE_ADDRESS to be an lvalue
Date: Sat, 20 Jul 2019 23:17:00 -0000 [thread overview]
Message-ID: <290eda910e16f817e2ba298b17db7254@polymtl.ca> (raw)
In-Reply-To: <20190627145235.21222-2-tromey@adacore.com>
On 2019-06-27 10:52, Tom Tromey wrote:
> This changes SYMBOL_VALUE_ADDRESS to be an lvalue. The symbol readers
> generally assign using this, so this also introduces
> SET_SYMBOL_VALUE_ADDRESS and updates the readers. Making this change
> is useful in a subsequent patch, which redefined SYMBOL_VALUE_ADDRESS.
Is the title (and commit message) backwards? SYMBOL_VALUE_ADDRESS(x) is
currently an lvalue, and you are making it a not-lvalue, no?
Simon
next prev parent reply other threads:[~2019-07-20 23:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 14:52 [PATCH 0/4] Handle copy relocations and add $_ada_exception Tom Tromey
2019-06-27 14:52 ` [PATCH 3/4] Back out earlier Ada exception change Tom Tromey
2019-06-27 14:52 ` [PATCH 1/4] Change SYMBOL_VALUE_ADDRESS to be an lvalue Tom Tromey
2019-07-20 23:17 ` Simon Marchi [this message]
2019-07-23 15:53 ` Tom Tromey
2019-06-27 14:52 ` [PATCH 2/4] Handle copy relocations Tom Tromey
2019-07-20 1:11 ` Pedro Alves
2019-07-30 21:00 ` Tom Tromey
2019-07-30 21:28 ` Tom Tromey
2019-07-31 19:21 ` Tom Tromey
2019-06-27 15:02 ` [PATCH 4/4] Add $_ada_exception convenience variable Tom Tromey
2019-06-27 17:35 ` Eli Zaretskii
2019-06-28 18:46 ` Tom Tromey
2019-06-28 19:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=290eda910e16f817e2ba298b17db7254@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox