From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91008 invoked by alias); 20 Jul 2019 23:17:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91000 invoked by uid 89); 20 Jul 2019 23:17:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_40,KAM_STOCKGEN,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 spammy=HX-Spam-Relays-External:Sendmail, H*RU:Sendmail, H*r:112, H*u:1.3.6 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 20 Jul 2019 23:17:33 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x6KNHOqh010381 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 20 Jul 2019 19:17:30 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x6KNHOqh010381 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1563664651; bh=Lau6FYE6jYGqz415qtJ5n4MAj45nvsKRMFuJ4e+276M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UNCRtPSN8GMC2/cb147aPCLUyCwWAZ2bCF2x+coqiTLDjPVfD5i7PCzVf/VMR5nwN rDnIfyVuZt4A+rVaArIdWon4tIbZ1G5qP5LI8nSfzHXOVR5eipIhjGoJmXca6/3iPx l/l9EV3bx0d75qaUirWn9DnaYXhmjl4RoA8Nb6mE= Received: by simark.ca (Postfix, from userid 112) id 4EC5D1EE70; Sat, 20 Jul 2019 19:17:24 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 471931E7D1; Sat, 20 Jul 2019 19:17:23 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 20 Jul 2019 23:17:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Change SYMBOL_VALUE_ADDRESS to be an lvalue In-Reply-To: <20190627145235.21222-2-tromey@adacore.com> References: <20190627145235.21222-1-tromey@adacore.com> <20190627145235.21222-2-tromey@adacore.com> Message-ID: <290eda910e16f817e2ba298b17db7254@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00484.txt.bz2 On 2019-06-27 10:52, Tom Tromey wrote: > This changes SYMBOL_VALUE_ADDRESS to be an lvalue. The symbol readers > generally assign using this, so this also introduces > SET_SYMBOL_VALUE_ADDRESS and updates the readers. Making this change > is useful in a subsequent patch, which redefined SYMBOL_VALUE_ADDRESS. Is the title (and commit message) backwards? SYMBOL_VALUE_ADDRESS(x) is currently an lvalue, and you are making it a not-lvalue, no? Simon