Re: [PATCH 1/3] gdb/testsuite: fix rust compiler selection in gdb_default_target_compile

[Andrew Burgess <aburgess@redhat.com>]

simon.marchi@polymtl.ca writes:

> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> The "set compiler" line looks like a copy-paste error from the if just
> above.  If we compare this to the Go handler, then it seems clear that the
> intent was to write:
>
> 	    if {[board_info $dest exists rustcompiler]} {
> 		set compiler [target_info rustcompiler]
> 	    } else {
> 		set compiler [find_rustc]
> 	    }
>
> The name rustcompiler follows the convention used by other languages (e.g.
> "gocompiler", "dcompiler", etc).
>
> This also matches what was sent upstream to DejaGnu in commit c8beff4a0843
> ("Add Rust support to default_target_compile").

LGTM.

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew


>
> Change-Id: Ic21b397ff6a2afbcda72901203ff7834c752ff3f
> ---
>  gdb/testsuite/lib/future.exp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp
> index 44fc17b3f004..a5444df66c87 100644
> --- a/gdb/testsuite/lib/future.exp
> +++ b/gdb/testsuite/lib/future.exp
> @@ -308,8 +308,8 @@ proc gdb_default_target_compile_1 {source destfile type options} {
>  	    if {[board_info $dest exists rustflags]} {
>  		append add_flags " [target_info rustflags]"
>  	    }
> -	    if {[board_info $dest exists rustflags]} {
> -		set compiler [target_info rustflags]
> +	    if {[board_info $dest exists rustcompiler]} {
> +		set compiler [target_info rustcompiler]
>  	    } else {
>  		set compiler [find_rustc]
>  	    }
>
> base-commit: 2ce6c3190773eb22f467446c4fdc7edb123ce82f
> -- 
> 2.55.0