From: Andrew Burgess <aburgess@redhat.com>
To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH 2/3] gdb/testsuite: wrap rustc in cc-with-tweaks.exp
Date: Tue, 06 Oct 2026 11:56:22 +0100 [thread overview]
Message-ID: <875wzfumg9.fsf@redhat.com> (raw)
In-Reply-To: <20261005052602.1288766-2-simon.marchi@polymtl.ca>
simon.marchi@polymtl.ca writes:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> I noticed that the gdb.rust/* executables did not contain a .gdb_index when
> run with the cc-with-gdb-index board. This is because cc-with-tweaks.exp
> does not wrap RUSTC_FOR_TARGET yet.
>
> Wrap RUSTC_FOR_TARGET too, the same way as for the other compilers.
>
> I can now see a .gdb_index in the produced executable. I do not see a
> difference in the test results, which I guess is a good sign.
LGTM.
Approved-By: Andrew Burgess <aburgess@redhat.com>
Thanks,
Andrew
>
> Change-Id: If950c2c4f851b93142e6e7c068444043feff5612
> ---
> gdb/testsuite/boards/cc-with-tweaks.exp | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/gdb/testsuite/boards/cc-with-tweaks.exp b/gdb/testsuite/boards/cc-with-tweaks.exp
> index 1f981414b396..08b4a9e4da48 100644
> --- a/gdb/testsuite/boards/cc-with-tweaks.exp
> +++ b/gdb/testsuite/boards/cc-with-tweaks.exp
> @@ -44,6 +44,7 @@ set found_gcc [find_gcc]
> set found_gxx [find_g++]
> set found_gnatmake [find_gnatmake]
> set found_f90 [find_gfortran]
> +set found_rustc [find_rustc]
> set_board_info compiler "$found_gcc"
>
> set contrib_dir [file normalize $srcdir/../contrib]
> @@ -63,6 +64,10 @@ if ![info exists F90_FOR_TARGET] {
> set F90_FOR_TARGET "$found_f90"
> }
> set F90_FOR_TARGET "$contrib_dir/cc-with-tweaks.sh $CC_WITH_TWEAKS_FLAGS $F90_FOR_TARGET"
> +if ![info exists RUSTC_FOR_TARGET] {
> + set RUSTC_FOR_TARGET "$found_rustc"
> +}
> +set RUSTC_FOR_TARGET "$contrib_dir/cc-with-tweaks.sh $CC_WITH_TWEAKS_FLAGS $RUSTC_FOR_TARGET"
>
> set env(GDB) \
> [cached_file gdb.sh "$GDB $INTERNAL_GDBFLAGS $GDBFLAGS \"\$@\"" 1]
> --
> 2.55.0
next prev parent reply other threads:[~2026-10-06 10:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 5:25 [PATCH 1/3] gdb/testsuite: fix rust compiler selection in gdb_default_target_compile simon.marchi
2026-10-05 5:25 ` [PATCH 2/3] gdb/testsuite: wrap rustc in cc-with-tweaks.exp simon.marchi
2026-10-06 10:56 ` Andrew Burgess [this message]
2026-10-05 5:25 ` [PATCH 3/3] gdb/dwarf: fix crash when .gdb_index contains Rust legacy mangled names simon.marchi
2026-10-06 11:01 ` Andrew Burgess
2026-10-06 13:39 ` Simon Marchi
2026-10-14 13:01 ` Tom Tromey
2026-10-14 13:22 ` Simon Marchi
2026-10-14 14:59 ` Tom Tromey
2026-10-14 16:13 ` Tom Tromey
2026-10-14 16:26 ` Simon Marchi
2026-10-14 16:46 ` [PATCH v2 0/2] Fix " Simon Marchi
2026-10-15 15:47 ` Tom Tromey
2026-10-18 3:45 ` Simon Marchi
2026-10-14 16:46 ` [PATCH v2 1/2] gdb: add selftests for split_name Simon Marchi
2026-10-15 15:48 ` Tom Tromey
2026-10-15 18:33 ` Simon Marchi
2026-10-16 3:15 ` Tom Tromey
2026-10-14 16:46 ` [PATCH v2 2/2] gdb/dwarf: fix crash when .gdb_index contains Rust legacy mangled names Simon Marchi
2026-10-06 10:56 ` [PATCH 1/3] gdb/testsuite: fix rust compiler selection in gdb_default_target_compile Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875wzfumg9.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox