Re: [PATCH v2 1/2] gdb: add selftests for split_name

[Simon Marchi <simark@simark.ca>]

On 10/15/26 11:48 AM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> +  if (result != expected)
> Simon> +    debug_printf ("split_name (\"%s\"): got %s, expected %s\n", name,
> Simon> +		  components_to_string (result).c_str (),
> Simon> +		  components_to_string (expected).c_str ());
> Simon> +
> Simon> +  SELF_CHECK (result == expected);
> 
> I've often regretted not adding a SELF_CHECK variant that takes two
> arguments, and then prints them both when the comparison fails.

It's funny that you say that because yesterday I was thinking how our
SELF_CHECK macro could do like catch2's CHECK/REQUIRE macro and automatically do
that.  I don't know if you have used catch2 before, but the output of a
failing test is:

catch2.cpp:26: FAILED:
  CHECK( reverse_string("hello") == "bonjour" )
with expansion:
  "olleh" == "bonjour"

I dismissed the idea because I thought people would find it's too much
complexity for nothing, but if you are interested I'd be happy to look
into it.

Simon