From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gcc-patches@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/2] gdb: add selftests for split_name
Date: Thu, 15 Oct 2026 09:48:52 -0600 [thread overview]
Message-ID: <878q3z2cd7.fsf@tromey.com> (raw)
In-Reply-To: <20261014164830.358677-2-simon.marchi@efficios.com> (Simon Marchi's message of "Wed, 14 Oct 2026 12:46:58 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> + if (result != expected)
Simon> + debug_printf ("split_name (\"%s\"): got %s, expected %s\n", name,
Simon> + components_to_string (result).c_str (),
Simon> + components_to_string (expected).c_str ());
Simon> +
Simon> + SELF_CHECK (result == expected);
I've often regretted not adding a SELF_CHECK variant that takes two
arguments, and then prints them both when the comparison fails.
Tom
next prev parent reply other threads:[~2026-10-15 15:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 5:25 [PATCH 1/3] gdb/testsuite: fix rust compiler selection in gdb_default_target_compile simon.marchi
2026-10-05 5:25 ` [PATCH 2/3] gdb/testsuite: wrap rustc in cc-with-tweaks.exp simon.marchi
2026-10-06 10:56 ` Andrew Burgess
2026-10-05 5:25 ` [PATCH 3/3] gdb/dwarf: fix crash when .gdb_index contains Rust legacy mangled names simon.marchi
2026-10-06 11:01 ` Andrew Burgess
2026-10-06 13:39 ` Simon Marchi
2026-10-14 13:01 ` Tom Tromey
2026-10-14 13:22 ` Simon Marchi
2026-10-14 14:59 ` Tom Tromey
2026-10-14 16:13 ` Tom Tromey
2026-10-14 16:26 ` Simon Marchi
2026-10-14 16:46 ` [PATCH v2 0/2] Fix " Simon Marchi
2026-10-15 15:47 ` Tom Tromey
2026-10-18 3:45 ` Simon Marchi
2026-10-14 16:46 ` [PATCH v2 1/2] gdb: add selftests for split_name Simon Marchi
2026-10-15 15:48 ` Tom Tromey [this message]
2026-10-15 18:33 ` Simon Marchi
2026-10-16 3:15 ` Tom Tromey
2026-10-14 16:46 ` [PATCH v2 2/2] gdb/dwarf: fix crash when .gdb_index contains Rust legacy mangled names Simon Marchi
2026-10-06 10:56 ` [PATCH 1/3] gdb/testsuite: fix rust compiler selection in gdb_default_target_compile Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878q3z2cd7.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gcc-patches@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox