From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8XfoCRP20GpjThIAWB0awg (envelope-from ) for ; Thu, 15 Oct 2026 11:49:39 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pN2jc/CP; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1F8811E050; Thu, 15 Oct 2026 11:49:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 689AA1E04E for ; Thu, 15 Oct 2026 11:49:38 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E3D944BA23F7 for ; Thu, 15 Oct 2026 15:49:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E3D944BA23F7 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pN2jc/CP Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 7400A4BA23D1 for ; Thu, 15 Oct 2026 15:48:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7400A4BA23D1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7400A4BA23D1 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792079336; cv=none; b=UKwqM+NcFq0pnEujVdaf96G/J64Na4yNHTSO6fXMPAvCNuQEazKbrHTVv377jQauj0j/GB0G39J04ScVluKTnjkVtEYewi5vadiKc2yC8vjQ8Q2oT/HOMfgviDzra1jfsqP/5qO8sU7CddYALxW061q7qnbcF/4kSeCMkrsMrwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792079336; c=relaxed/simple; bh=2u+uYp5Ykjcn3r8cXxsgbPAP2xfgtbIA4DoVCc6bLdM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HxXYYNF1c+EwjZppshVr+idB9RlieDY9mT6x1wELcbHtJe0zhSwaGETM3hcQwwAUQsN+kT57OUUNr+EPyjljYUunJ+QjVBAMcnDOXVEeErlSaRT5K36S0Lo7POUDhQUxSMmoUXdG712tTaHtSqPNpirQSxw8XZ9ezwKrf1cz2Hw= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pN2jc/CP reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7400A4BA23D1 Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id GdOfxucOwMylkHNhQxd0k0; Thu, 15 Oct 2026 15:48:56 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id HNhNxOQzibhSyHNhOx8BO2; Thu, 15 Oct 2026 15:48:54 +0000 X-Authority-Analysis: v=2.4 cv=IJECChvG c=1 sm=1 tr=0 ts=6ad0f5e6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=vDaSZF9cneGDihlHnYcA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d2Wy2oUo2w9nITSv+Stg/c9vWQTov7X+lgf7nIPzRd4=; b=pN2jc/CP9kJwhPHLVSTIJO7gpl RWGy4v8r/mIrWdQbEhBD+3oPu3+K7WhEbH7sNoPwFHuOjLnaa7aesA9YHdOaLl/r0Zvlm2uArR8Z2 vucPzFSIk1cUQ657lL87w39b7; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:51368 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xHNhN-00000003ALC-1sSv; Thu, 15 Oct 2026 09:48:53 -0600 From: Tom Tromey To: Simon Marchi Cc: gcc-patches@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/2] gdb: add selftests for split_name In-Reply-To: <20261014164830.358677-2-simon.marchi@efficios.com> (Simon Marchi's message of "Wed, 14 Oct 2026 12:46:58 -0400") References: <20261005052602.1288766-3-simon.marchi@polymtl.ca> <20261014164830.358677-2-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 15 Oct 2026 09:48:52 -0600 Message-ID: <878q3z2cd7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xHNhN-00000003ALC-1sSv X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:51368 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOHMfM19hVEtMfxj9jia6a4puzE9cvLM4tcJFVAVRUBc50fiiGa6qhEKCU5ILDx4sN0fVsk2UqhkV6xMS/NjoMLeZmCVt0uZpUridJvJHHNzgJzjj7hF TAf8NXUi9N0CnnJZ5eDSJ1T7c5FYRC2UsQTUV9vkZcmesuY/8BO1yTSBmxx1WvLOCilI27Oj5mZS8scm7j7TykH3dEtGIiH8Cuk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> + if (result != expected) Simon> + debug_printf ("split_name (\"%s\"): got %s, expected %s\n", name, Simon> + components_to_string (result).c_str (), Simon> + components_to_string (expected).c_str ()); Simon> + Simon> + SELF_CHECK (result == expected); I've often regretted not adding a SELF_CHECK variant that takes two arguments, and then prints them both when the comparison fails. Tom