Re: [PATCH 3/3] gdb/dwarf: fix crash when .gdb_index contains Rust legacy mangled names

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:

Simon> Since this name does not match the C++ and Ada special cases, it falls into
Simon> the DOT_STYLE else:
Simon>     components = split_name (name, split_style::DOT_STYLE);
Simon> Because of the consecutive dots in the symbol name, `components` (an
Simon> std::vector<std::string_view>) contains some empty components.  Some code
Simon> later calls .back() on one of those empty string_views, which is invalid.

It seems to me that a "dot-style" name could never have two consecutive
dots.  So, how about changing split_name to bail out in this case?

I see I didn't write any unit tests for split-name.c, which seems like a
real oversight.

Simon> I can't think of a pretty way to fix this.  Since we don't have a flag that
Simon> tells us whether a name is a linkage name or not, we can only make some
Simon> educated guesses.

Yeah.  I think we've resisted doing this.  But maybe we should just give
in and look for a leading _Z/_R.

Tom