From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0aOFJFh9z2ra0wgAWB0awg (envelope-from ) for ; Wed, 14 Oct 2026 09:02:16 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dza4qfUl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 90F811E051; Wed, 14 Oct 2026 09:02:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0CC781E04E for ; Wed, 14 Oct 2026 09:02:16 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B4B14BA23D5 for ; Wed, 14 Oct 2026 13:02:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B4B14BA23D5 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dza4qfUl Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 391CB4BA2E1D for ; Wed, 14 Oct 2026 13:01:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 391CB4BA2E1D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 391CB4BA2E1D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791982906; cv=none; b=a242U5aP6mNVNIyCVmPPm5UcBrxRtm93igKXxSSPat4wuFJGg9CI24e44okTu6ls/ugCS2a1tv5trKnie0usCIfKZAh2i9P2dTgev5YxDJYoPWCjs1evuLSBeNkBv4qwzN43XiDeoqADwEznlY4wj4BDfPesZiVrXFjUbSPuRcs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791982906; c=relaxed/simple; bh=k4b0jlygeOG8xwaGvGO8dVqEGRuZ+9udPF7dQbcz5Yk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QUeHp1SzV/Yvi2lsfQ1uKZ7ZXgkXAYox5ZYJqAKhBpbQ2bnrqf5eFp19z33noqcxT96iDbf1KBn9q0NqIUS1ofCJvVY7OV86p6uTCd5xAzAQ7Lx2/7nDAF2CH8kgN2Mf5QKr3Vt5GfHLr4Fbve6DQHwYMNUwjVp/yptfgMfbY6k= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dza4qfUl reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 391CB4BA2E1D Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id GdOkxuchrMylkGyc5xRWkx; Wed, 14 Oct 2026 13:01:45 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Gyc1x8zxyvvPpGyc1xxKTY; Wed, 14 Oct 2026 13:01:41 +0000 X-Authority-Analysis: v=2.4 cv=WqUrMcfv c=1 sm=1 tr=0 ts=6acf7d39 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=eoqt36JFx6TGZ_xdcacA:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mB7cLeaFmx/lx4FfoWs4+lul4vhUdUeVF13evH5ONcc=; b=dza4qfUlE8KnZuPglCC1oxXt2R UGc9n6/OXi1YOhIk+OoDB7x7Q7VE8wXKpXtPVWUo30frUw4BX4BE+LCJUQJwSBHDyJQJFIFqqfCGR kBKAFLVH+x4vuzkQH9TxhEJbt; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:38610 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xGyc1-000000032Xi-0AZ3; Wed, 14 Oct 2026 07:01:41 -0600 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] gdb/dwarf: fix crash when .gdb_index contains Rust legacy mangled names In-Reply-To: <20261005052602.1288766-3-simon.marchi@polymtl.ca> (simon marchi's message of "Mon, 5 Oct 2026 01:25:49 -0400") References: <20261005052602.1288766-1-simon.marchi@polymtl.ca> <20261005052602.1288766-3-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Wed, 14 Oct 2026 07:01:39 -0600 Message-ID: <874ieo5tcc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xGyc1-000000032Xi-0AZ3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:38610 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAL0b6nYgVJSN0lUdkolXxfewbCufAIf1S1OZOxjZTaU3+ZZph33MkB8SWt1hn1olQIFbAcKBy3L1+059Jhjco4RFl5SyNu/42FGIhCLqw9B1RLTQfoR XYW00YUfBZJyPQDzpxRy2RoaOZwhU9zjxLUY4+jAMRlHXrqRySAYk1/XiGNA2Lx+9KqsC7hx9FP4oP/sOYMc63h7IPSAD+zq6iM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> Since this name does not match the C++ and Ada special cases, it falls into Simon> the DOT_STYLE else: Simon> components = split_name (name, split_style::DOT_STYLE); Simon> Because of the consecutive dots in the symbol name, `components` (an Simon> std::vector) contains some empty components. Some code Simon> later calls .back() on one of those empty string_views, which is invalid. It seems to me that a "dot-style" name could never have two consecutive dots. So, how about changing split_name to bail out in this case? I see I didn't write any unit tests for split-name.c, which seems like a real oversight. Simon> I can't think of a pretty way to fix this. Since we don't have a flag that Simon> tells us whether a name is a linkage name or not, we can only make some Simon> educated guesses. Yeah. I think we've resisted doing this. But maybe we should just give in and look for a leading _Z/_R. Tom