From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KUw9DQfUxGoU4gMAWB0awg (envelope-from ) for ; Tue, 06 Oct 2026 06:57:11 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=T6LRoAgb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 297801E051; Tue, 06 Oct 2026 06:57:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 90A471E04E for ; Tue, 06 Oct 2026 06:57:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C1E254BB58D1 for ; Tue, 6 Oct 2026 10:57:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1E254BB58D1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=T6LRoAgb Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id BF7474BA2E13 for ; Tue, 6 Oct 2026 10:56:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF7474BA2E13 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF7474BA2E13 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791284179; cv=none; b=u5NzOAp+b4Ot6Z8QjAzirf7/g1XIFIqOtwd+mQ8tzmyggv0jqOI0HDInJ/iBFbFAaQChUQ/duWxpVNxY+/eocY/Th+ml7+SZIhd4/BUK8aOns/QYdpeElX1ifME9L1gABUE54h0DxxCguPWKBdaX0gd339q3deedqeeTcCrkgc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791284179; c=relaxed/simple; bh=zk4M8O5LJ3lj+hzt/vsrYePmbzmlY9QYOIUKjrvJGhc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nLu7ureIVhcp6IME8Gd7TPwBn8roZL9zacMYmCq2C9dpnmmtK35wh2R+gK4jEyd7vG9KaCDYdfft6V/C26cL39vxYZD3OYGFgBzJWQ+3jWpmtGtHggu5YwfKVZAym2s0a6kXTgNnT86pBdKrrLNKAr9DD7DZeATfIFJW15rFyYA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=T6LRoAgb DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BF7474BA2E13 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791284179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k2QG5AUouRj87w/sLDG7fVXUf+KdRruXIluE+KwRvms=; b=T6LRoAgbrsdU0zMQd5LWHZCKkF8lCJyJR5SNbT5wNygFlGuRQHVrYQc3Deb4qkZcGXI3/h QCS++3mLb6fzlbguH7zl/VsCc+n7BKpx7WgAn+kl7+1RtzzsUBM0H6Bk5xJIhw0BWKPIT1 vPQlwCpn8UIh3Cg1CipJgiBN5v5IeBE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-v4FSsd0nOQigPEd_DRWWzQ-1; Tue, 06 Oct 2026 06:56:18 -0400 X-MC-Unique: v4FSsd0nOQigPEd_DRWWzQ-1 X-Mimecast-MFC-AGG-ID: v4FSsd0nOQigPEd_DRWWzQ_1791284177 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a019d53f46so21688655e9.3 for ; Tue, 06 Oct 2026 03:56:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791284177; x=1791888977; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=k2QG5AUouRj87w/sLDG7fVXUf+KdRruXIluE+KwRvms=; b=XTd+GXfYzFEJGRxXt+M+g5dmtWCkZTiGpcj55orNBQcuMy3sHq8s9s34x6Ko9VLf08 qTIMWT446M2w7iv8fX31dpZSUgz6W0roEC7uYNpTcopZlTiaZ4Em2jZ/nVkPpbl6jF/j VZIwj/RNHJoMkPRYJrc1m7F+OcMj8htw1/L5O6/OOEZV2sPkJH4WGwsbbfKwUnxlhIHJ prW858IYuOzwk99ICFyTEdi59k53LYIay9gKNzORGv20fKx2+qoreiMX+WsNByviuD9U cnsrjwWNC82dd5A0pMMu361VrpJC8PE7Xs4VunsvtdCVq3T+wwf354Ly5q4LQCpmQuTj BTkA== X-Forwarded-Encrypted: i=1; AKwUvBzPRNYjyqAevx/PE6xsxwOlmj7GF7uWjBFE27Skw74gAz+Dt+SjpYzkNfklaBkWs0cfk1+svkZ1y4JjxA==@sourceware.org X-Gm-Message-State: AFq9FYKDvzTWkdfNSbroRlZ4wtuP5FMtnA60b1uJi4OlwYT420fHq0GD lILHASDyKph4qNWgTTaJFWJExHGiCRFgtXEVX8mQuS47n1Pi9QRgnjeOsS+hbOlChuq0MO9W0E2 c7mN64E7SBCrneBwU8JJ2DklV89LgV4d0GjU+GRTZN0EK/Qnqy0iNd1sw62JCyNs02xbUeFI= X-Gm-Gg: AYBFou0C1ubXZILYWhCab5KpF5oLXolcwMQN8OpO3yQ5Jb9Kt4jRKw8GWdZir46WQ+j 6XllZu8uee7MkL9szzbSfjaKyR9jiMvzWU9iv7U7tWH2In7b+vE3l4tOlgS2LLbO9nWeZSX/kxD lVv04UXY1DIyQZMZb+m1LF4yLkW82M4+S2RP8QHLfS1JC+vbHBa/xzL6n+mfTL6hAj4OssIZSpu WbPf3IY0vlbQbc30NQeN8A5re9tTwpA3ZMRHqDNqAZjLFr7qNyiCddAtmLp+Y1yHMwZGdljkbc6 BWn0iuvHJUexAUHwef78QvKeLJmx3LKASc765PsP5Lf/DlJUwbkZyVIh/IZA8YhZTt2L X-Received: by 2002:a05:6000:40da:b0:48b:6b4:db5c with SMTP id ffacd0b85a97d-48c6d0f4b86mr1966323f8f.6.1791284176917; Tue, 06 Oct 2026 03:56:16 -0700 (PDT) X-Received: by 2002:a05:6000:40da:b0:48b:6b4:db5c with SMTP id ffacd0b85a97d-48c6d0f4b86mr1966281f8f.6.1791284176356; Tue, 06 Oct 2026 03:56:16 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48c622ab5a1sm9437923f8f.36.2026.10.06.03.56.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 03:56:15 -0700 (PDT) From: Andrew Burgess To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 1/3] gdb/testsuite: fix rust compiler selection in gdb_default_target_compile In-Reply-To: <20261005052602.1288766-1-simon.marchi@polymtl.ca> References: <20261005052602.1288766-1-simon.marchi@polymtl.ca> Date: Tue, 06 Oct 2026 11:56:14 +0100 Message-ID: <878q4bumgh.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pBJMfThO3KOllPPgU6RcSdX6APmJhKNLhva2RFanAzE_1791284177 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org simon.marchi@polymtl.ca writes: > From: Simon Marchi > > The "set compiler" line looks like a copy-paste error from the if just > above. If we compare this to the Go handler, then it seems clear that the > intent was to write: > > if {[board_info $dest exists rustcompiler]} { > set compiler [target_info rustcompiler] > } else { > set compiler [find_rustc] > } > > The name rustcompiler follows the convention used by other languages (e.g. > "gocompiler", "dcompiler", etc). > > This also matches what was sent upstream to DejaGnu in commit c8beff4a0843 > ("Add Rust support to default_target_compile"). LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: Ic21b397ff6a2afbcda72901203ff7834c752ff3f > --- > gdb/testsuite/lib/future.exp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp > index 44fc17b3f004..a5444df66c87 100644 > --- a/gdb/testsuite/lib/future.exp > +++ b/gdb/testsuite/lib/future.exp > @@ -308,8 +308,8 @@ proc gdb_default_target_compile_1 {source destfile type options} { > if {[board_info $dest exists rustflags]} { > append add_flags " [target_info rustflags]" > } > - if {[board_info $dest exists rustflags]} { > - set compiler [target_info rustflags] > + if {[board_info $dest exists rustcompiler]} { > + set compiler [target_info rustcompiler] > } else { > set compiler [find_rustc] > } > > base-commit: 2ce6c3190773eb22f467446c4fdc7edb123ce82f > -- > 2.55.0