From: Tom Tromey <tom@tromey.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 5/6] Change Ada exceptions to use std::string
Date: Thu, 30 Nov 2017 23:53:00 -0000 [thread overview]
Message-ID: <874lpbuxvu.fsf@tromey.com> (raw)
In-Reply-To: <20171130225916.csgxhw2gcauyby6x@adacore.com> (Joel Brobecker's message of "Thu, 30 Nov 2017 17:59:16 -0500")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> (I tested my patch on x86_64-linux, limiting myself to gdb.ada)
Joel> Pb #1: Crash while trying to insert an assert catchpoint:
I wonder why I didn't see any problems from the buildbot.
Joel> Pb #3: condition handling in exception catchpoints is broken
Joel> Tom removed a call to "skip_spaces" before checking for the next
Joel> argument, and I am not sure I understand why.
Here I was confused and thought extract_arg skipped spaces again after
extracting the arg. But, it doesn't.
Still - why not test failures? This is disturbing.
Tom
next prev parent reply other threads:[~2017-11-30 23:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 3:01 [RFA 0/6] remove cleanups from Ada Tom Tromey
2017-11-30 3:01 ` [RFA 1/6] Remove cleanup from old_renaming_is_invisible Tom Tromey
2017-11-30 3:01 ` [RFA 3/6] Remove cleanup from print_mention_exception Tom Tromey
2017-11-30 3:01 ` [RFA 6/6] Remove unnecessary cleanup from ada_collect_symbol_completion_matches Tom Tromey
2017-11-30 3:01 ` [RFA 2/6] Remove cleanup from create_excep_cond_exprs Tom Tromey
2017-11-30 3:01 ` [RFA 5/6] Change Ada exceptions to use std::string Tom Tromey
2017-11-30 22:03 ` Joel Brobecker
2017-11-30 22:59 ` Joel Brobecker
2017-11-30 23:53 ` Tom Tromey [this message]
2017-12-01 12:10 ` Joel Brobecker
2017-11-30 3:01 ` [RFA 4/6] Remove some more cleanups from ada-lang.c Tom Tromey
2017-11-30 22:02 ` [RFA 0/6] remove cleanups from Ada Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lpbuxvu.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox