From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 0/6] remove cleanups from Ada
Date: Thu, 30 Nov 2017 22:02:00 -0000 [thread overview]
Message-ID: <20171130220204.ewblkawcu5kvwidx@adacore.com> (raw)
In-Reply-To: <20171130030140.14830-1-tom@tromey.com>
Hi Tom,
> This series removes the remaining cleanups from ada-lang.c.
> Regression tested by the buildbot.
Thanks for doing that. All patches looked good to me, except one of
them, where I found a number of issues (thanks to testing). All
those issues except potentially one of them (still to be verified)
were also caught by the testsuite already available, so I'm not sure
why the buildbot didn't catch them. Perhaps the Ada compiler available
there doesn't allow clean results for exception catchpoints to start
with. In any case, I will send my fixes as answer to that one patch.
All other patches are OK.
--
Joel
prev parent reply other threads:[~2017-11-30 22:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 3:01 Tom Tromey
2017-11-30 3:01 ` [RFA 2/6] Remove cleanup from create_excep_cond_exprs Tom Tromey
2017-11-30 3:01 ` [RFA 5/6] Change Ada exceptions to use std::string Tom Tromey
2017-11-30 22:03 ` Joel Brobecker
2017-11-30 22:59 ` Joel Brobecker
2017-11-30 23:53 ` Tom Tromey
2017-12-01 12:10 ` Joel Brobecker
2017-11-30 3:01 ` [RFA 4/6] Remove some more cleanups from ada-lang.c Tom Tromey
2017-11-30 3:01 ` [RFA 1/6] Remove cleanup from old_renaming_is_invisible Tom Tromey
2017-11-30 3:01 ` [RFA 3/6] Remove cleanup from print_mention_exception Tom Tromey
2017-11-30 3:01 ` [RFA 6/6] Remove unnecessary cleanup from ada_collect_symbol_completion_matches Tom Tromey
2017-11-30 22:02 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130220204.ewblkawcu5kvwidx@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox