Re: [RFA 5/6] Change Ada exceptions to use std::string

[Joel Brobecker <brobecker@adacore.com>]

Hi Tom,

> This changes the Ada exception code to use std::string, allowing the
> removal of some more cleanups.
> 
> ChangeLog
> 2017-11-29  Tom Tromey  <tom@tromey.com>
> 
> 	* mi/mi-cmd-catch.c (mi_cmd_catch_assert)
> 	(mi_cmd_catch_exception): Update.
> 	* ada-lang.h (create_ada_exception_catchpoint): Update.
> 	* ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
> 	std::string.
> 	(create_excep_cond_exprs, ~ada_catchpoint)
> 	(should_stop_exception, print_one_exception)
> 	(print_mention_exception, print_recreate_exception): Update.
> 	(ada_get_next_arg): Remove.
> 	(catch_ada_exception_command_split): Change two arguments to
> 	"std::string *".  Remove cleanups.
> 	(ada_exception_catchpoint_cond_string): Change "string" to
> 	std::string.
> 	(ada_exception_sal): Remove excep_string parameter.
> 	(create_ada_exception_catchpoint): Change two arguments to
> 	"std::string &&".
> 	(catch_ada_exception_command): Update.

As hinted in my answer to the cover email, I found a few issues.
Attached is a commit that explains and fixes them. If the fixes
look good to you, a new commit combining the two is preapproved.

(I tested my patch on x86_64-linux, limiting myself to gdb.ada)

Thanks!
-- 
Joel