From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA 3/6] Remove cleanup from print_mention_exception
Date: Thu, 30 Nov 2017 03:01:00 -0000 [thread overview]
Message-ID: <20171130030140.14830-4-tom@tromey.com> (raw)
In-Reply-To: <20171130030140.14830-1-tom@tromey.com>
This removes a cleanup from print_mention_exception by using
string_printf.
ChangeLog
2017-11-29 Tom Tromey <tom@tromey.com>
* ada-lang.c (print_mention_exception): Use std::string.
---
gdb/ChangeLog | 4 ++++
gdb/ada-lang.c | 8 +++-----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 28df250104..0248663ba8 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -12537,11 +12537,9 @@ print_mention_exception (enum ada_exception_catchpoint_kind ex,
case ada_catch_exception:
if (c->excep_string != NULL)
{
- char *info = xstrprintf (_("`%s' Ada exception"), c->excep_string);
- struct cleanup *old_chain = make_cleanup (xfree, info);
-
- uiout->text (info);
- do_cleanups (old_chain);
+ std::string info = string_printf (_("`%s' Ada exception"),
+ c->excep_string);
+ uiout->text (info.c_str ());
}
else
uiout->text (_("all Ada exceptions"));
--
2.13.6
next prev parent reply other threads:[~2017-11-30 3:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 3:01 [RFA 0/6] remove cleanups from Ada Tom Tromey
2017-11-30 3:01 ` [RFA 4/6] Remove some more cleanups from ada-lang.c Tom Tromey
2017-11-30 3:01 ` [RFA 5/6] Change Ada exceptions to use std::string Tom Tromey
2017-11-30 22:03 ` Joel Brobecker
2017-11-30 22:59 ` Joel Brobecker
2017-11-30 23:53 ` Tom Tromey
2017-12-01 12:10 ` Joel Brobecker
2017-11-30 3:01 ` [RFA 2/6] Remove cleanup from create_excep_cond_exprs Tom Tromey
2017-11-30 3:01 ` [RFA 6/6] Remove unnecessary cleanup from ada_collect_symbol_completion_matches Tom Tromey
2017-11-30 3:01 ` Tom Tromey [this message]
2017-11-30 3:01 ` [RFA 1/6] Remove cleanup from old_renaming_is_invisible Tom Tromey
2017-11-30 22:02 ` [RFA 0/6] remove cleanups from Ada Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130030140.14830-4-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox