From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 5/6] Change Ada exceptions to use std::string
Date: Fri, 01 Dec 2017 12:10:00 -0000 [thread overview]
Message-ID: <20171201121035.egda5pk5nngfstwd@adacore.com> (raw)
In-Reply-To: <874lpbuxvu.fsf@tromey.com>
> Joel> Pb #1: Crash while trying to insert an assert catchpoint:
>
> I wonder why I didn't see any problems from the buildbot.
>
> Joel> Pb #3: condition handling in exception catchpoints is broken
>
> Joel> Tom removed a call to "skip_spaces" before checking for the next
> Joel> argument, and I am not sure I understand why.
>
> Here I was confused and thought extract_arg skipped spaces again after
> extracting the arg. But, it doesn't.
>
> Still - why not test failures? This is disturbing.
That's indeed strange. Do we have access to the reference report?
Maybe the Ada testing is not run (eg: missing Ada compiler on
the buildbot), or maybe the Ada compiler there is such that the tests
were failing in the first place, preventing it from detecting
regressions?
In any case, I'm quite happy to be the safety net in this case...
--
Joel
next prev parent reply other threads:[~2017-12-01 12:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 3:01 [RFA 0/6] remove cleanups from Ada Tom Tromey
2017-11-30 3:01 ` [RFA 2/6] Remove cleanup from create_excep_cond_exprs Tom Tromey
2017-11-30 3:01 ` [RFA 5/6] Change Ada exceptions to use std::string Tom Tromey
2017-11-30 22:03 ` Joel Brobecker
2017-11-30 22:59 ` Joel Brobecker
2017-11-30 23:53 ` Tom Tromey
2017-12-01 12:10 ` Joel Brobecker [this message]
2017-11-30 3:01 ` [RFA 4/6] Remove some more cleanups from ada-lang.c Tom Tromey
2017-11-30 3:01 ` [RFA 1/6] Remove cleanup from old_renaming_is_invisible Tom Tromey
2017-11-30 3:01 ` [RFA 3/6] Remove cleanup from print_mention_exception Tom Tromey
2017-11-30 3:01 ` [RFA 6/6] Remove unnecessary cleanup from ada_collect_symbol_completion_matches Tom Tromey
2017-11-30 22:02 ` [RFA 0/6] remove cleanups from Ada Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201121035.egda5pk5nngfstwd@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox