From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69917 invoked by alias); 1 Dec 2017 12:10:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69907 invoked by uid 89); 1 Dec 2017 12:10:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Dec 2017 12:10:37 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EA6CA116B4E; Fri, 1 Dec 2017 07:10:35 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8JIm2jmjYQG8; Fri, 1 Dec 2017 07:10:35 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C24B8116B4D; Fri, 1 Dec 2017 07:10:35 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4C15D808DB; Fri, 1 Dec 2017 07:10:35 -0500 (EST) Date: Fri, 01 Dec 2017 12:10:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 5/6] Change Ada exceptions to use std::string Message-ID: <20171201121035.egda5pk5nngfstwd@adacore.com> References: <20171130030140.14830-1-tom@tromey.com> <20171130030140.14830-6-tom@tromey.com> <20171130220348.cqv3ik5c2lie7xm5@adacore.com> <20171130225916.csgxhw2gcauyby6x@adacore.com> <874lpbuxvu.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874lpbuxvu.fsf@tromey.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2017-12/txt/msg00019.txt.bz2 > Joel> Pb #1: Crash while trying to insert an assert catchpoint: > > I wonder why I didn't see any problems from the buildbot. > > Joel> Pb #3: condition handling in exception catchpoints is broken > > Joel> Tom removed a call to "skip_spaces" before checking for the next > Joel> argument, and I am not sure I understand why. > > Here I was confused and thought extract_arg skipped spaces again after > extracting the arg. But, it doesn't. > > Still - why not test failures? This is disturbing. That's indeed strange. Do we have access to the reference report? Maybe the Ada testing is not run (eg: missing Ada compiler on the buildbot), or maybe the Ada compiler there is such that the tests were failing in the first place, preventing it from detecting regressions? In any case, I'm quite happy to be the safety net in this case... -- Joel