From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125557 invoked by alias); 30 Nov 2017 22:03:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125543 invoked by uid 89); 30 Nov 2017 22:03:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=limiting X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Nov 2017 22:03:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1FDF411693B; Thu, 30 Nov 2017 17:03:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ag4Ibr5kcNSs; Thu, 30 Nov 2017 17:03:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 071321164EC; Thu, 30 Nov 2017 17:03:49 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 8C78C803E6; Thu, 30 Nov 2017 17:03:48 -0500 (EST) Date: Thu, 30 Nov 2017 22:03:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 5/6] Change Ada exceptions to use std::string Message-ID: <20171130220348.cqv3ik5c2lie7xm5@adacore.com> References: <20171130030140.14830-1-tom@tromey.com> <20171130030140.14830-6-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130030140.14830-6-tom@tromey.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2017-11/txt/msg00852.txt.bz2 Hi Tom, > This changes the Ada exception code to use std::string, allowing the > removal of some more cleanups. > > ChangeLog > 2017-11-29 Tom Tromey > > * mi/mi-cmd-catch.c (mi_cmd_catch_assert) > (mi_cmd_catch_exception): Update. > * ada-lang.h (create_ada_exception_catchpoint): Update. > * ada-lang.c (struct ada_catchpoint) : Now a > std::string. > (create_excep_cond_exprs, ~ada_catchpoint) > (should_stop_exception, print_one_exception) > (print_mention_exception, print_recreate_exception): Update. > (ada_get_next_arg): Remove. > (catch_ada_exception_command_split): Change two arguments to > "std::string *". Remove cleanups. > (ada_exception_catchpoint_cond_string): Change "string" to > std::string. > (ada_exception_sal): Remove excep_string parameter. > (create_ada_exception_catchpoint): Change two arguments to > "std::string &&". > (catch_ada_exception_command): Update. As hinted in my answer to the cover email, I found a few issues. Attached is a commit that explains and fixes them. If the fixes look good to you, a new commit combining the two is preapproved. (I tested my patch on x86_64-linux, limiting myself to gdb.ada) Thanks! -- Joel