From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124059 invoked by alias); 30 Nov 2017 22:02:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124050 invoked by uid 89); 30 Nov 2017 22:02:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Nov 2017 22:02:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3826F11693B; Thu, 30 Nov 2017 17:02:05 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HYB+H14mxYZT; Thu, 30 Nov 2017 17:02:05 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1DE901164EC; Thu, 30 Nov 2017 17:02:05 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A0C89803E6; Thu, 30 Nov 2017 17:02:04 -0500 (EST) Date: Thu, 30 Nov 2017 22:02:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 0/6] remove cleanups from Ada Message-ID: <20171130220204.ewblkawcu5kvwidx@adacore.com> References: <20171130030140.14830-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130030140.14830-1-tom@tromey.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2017-11/txt/msg00851.txt.bz2 Hi Tom, > This series removes the remaining cleanups from ada-lang.c. > Regression tested by the buildbot. Thanks for doing that. All patches looked good to me, except one of them, where I found a number of issues (thanks to testing). All those issues except potentially one of them (still to be verified) were also caught by the testsuite already available, so I'm not sure why the buildbot didn't catch them. Perhaps the Ada compiler available there doesn't allow clean results for exception catchpoints to start with. In any case, I will send my fixes as answer to that one patch. All other patches are OK. -- Joel