From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75356 invoked by alias); 30 Nov 2017 23:53:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74992 invoked by uid 89); 30 Nov 2017 23:53:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Nov 2017 23:53:28 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway24.websitewelcome.com (Postfix) with ESMTP id BE9105315A for ; Thu, 30 Nov 2017 17:53:26 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id KYdye5dzzvkfxKYdyekMQN; Thu, 30 Nov 2017 17:53:26 -0600 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:51296 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eKYdy-002F9i-H1; Thu, 30 Nov 2017 17:53:26 -0600 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 5/6] Change Ada exceptions to use std::string References: <20171130030140.14830-1-tom@tromey.com> <20171130030140.14830-6-tom@tromey.com> <20171130220348.cqv3ik5c2lie7xm5@adacore.com> <20171130225916.csgxhw2gcauyby6x@adacore.com> Date: Thu, 30 Nov 2017 23:53:00 -0000 In-Reply-To: <20171130225916.csgxhw2gcauyby6x@adacore.com> (Joel Brobecker's message of "Thu, 30 Nov 2017 17:59:16 -0500") Message-ID: <874lpbuxvu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eKYdy-002F9i-H1 X-Source-Sender: 71-218-90-63.hlrn.qwest.net (bapiya) [71.218.90.63]:51296 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2017-11/txt/msg00856.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> (I tested my patch on x86_64-linux, limiting myself to gdb.ada) Joel> Pb #1: Crash while trying to insert an assert catchpoint: I wonder why I didn't see any problems from the buildbot. Joel> Pb #3: condition handling in exception catchpoints is broken Joel> Tom removed a call to "skip_spaces" before checking for the next Joel> argument, and I am not sure I understand why. Here I was confused and thought extract_arg skipped spaces again after extracting the arg. But, it doesn't. Still - why not test failures? This is disturbing. Tom