New ARI warning Mon May 14 01:55:48 UTC 2012

New ARI warning Mon May 14 01:55:48 UTC 2012

[GDB Administrator]

719a720
> gdb/python/python.c:642: code: long long: Do not use 'long long', instead use LONGEST
gdb/python/python.c:642:  unsigned long long pc_llu;

Re: New ARI warning Mon May 14 01:55:48 UTC 2012

[Siva Chandra]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

On Mon, May 14, 2012 at 7:25 AM, GDB Administrator
<gdbadmin@sourceware.org> wrote:
> 719a720
>> gdb/python/python.c:642: code: long long: Do not use 'long long', instead use LONGEST
> gdb/python/python.c:642:  unsigned long long pc_llu;

Committed the attached patch as obvious to fix this.

2012-05-14  Siva Chandra Reddy  <sivachandra@google.com>

        * python/python.c (gdbpy_find_pc_line): Use ULONGEST instead of
        unsigned long long.


Thanks,
Siva Chandra

[-- Attachment #2: ari_fix.txt --]
[-- Type: text/plain, Size: 527 bytes --]

Index: python/python.c
===================================================================
RCS file: /cvs/src/src/gdb/python/python.c,v
retrieving revision 1.87
diff -u -p -r1.87 python.c
--- python/python.c	13 May 2012 11:33:43 -0000	1.87
+++ python/python.c	14 May 2012 03:05:32 -0000
@@ -639,7 +639,7 @@ gdbpy_find_pc_line (PyObject *self, PyOb
 {
   struct symtab_and_line sal;
   CORE_ADDR pc;
-  unsigned long long pc_llu;
+  ULONGEST pc_llu;
 
   if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc_llu))
     return NULL;

Re: New ARI warning Mon May 14 01:55:48 UTC 2012

[Tom Tromey]

>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:

Siva>         * python/python.c (gdbpy_find_pc_line): Use ULONGEST instead of
Siva>         unsigned long long.

Siva> -  unsigned long long pc_llu;
Siva> +  ULONGEST pc_llu;
 
Siva>    if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc_llu))
Siva>      return NULL;

GDB_PY_LLU_ARG should be used with gdb_py_ulongest.  What this type
refers to depends on configure.  It is done this way to let us handle
multiple Python versions in the same sources.  Your patch probably
breaks on some version or another.  See python-internal.h.

Tom

Re: New ARI warning Mon May 14 01:55:48 UTC 2012

[Tom Tromey]

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> GDB_PY_LLU_ARG should be used with gdb_py_ulongest.  What this type
Tom> refers to depends on configure.  It is done this way to let us handle
Tom> multiple Python versions in the same sources.  Your patch probably
Tom> breaks on some version or another.  See python-internal.h.

It was simplest to just fix it.
Patch appended.

Tom

2012-05-15  Tom Tromey  <tromey@redhat.com>

	* python/python.c (gdbpy_find_pc_line): Use gdb_py_ulongest.

Index: python/python.c
===================================================================
RCS file: /cvs/src/src/gdb/python/python.c,v
retrieving revision 1.88
diff -u -r1.88 python.c
--- python/python.c	14 May 2012 03:06:47 -0000	1.88
+++ python/python.c	15 May 2012 20:25:15 -0000
@@ -639,7 +639,7 @@
 {
   struct symtab_and_line sal;
   CORE_ADDR pc;
-  ULONGEST pc_llu;
+  gdb_py_ulongest pc_llu;
 
   if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc_llu))
     return NULL;

Re: New ARI warning Mon May 14 01:55:48 UTC 2012

[Siva Chandra]

Tom> GDB_PY_LLU_ARG should be used with gdb_py_ulongest.  What this type
Tom> refers to depends on configure.  It is done this way to let us handle
Tom> multiple Python versions in the same sources.  Your patch probably
Tom> breaks on some version or another.  See python-internal.h.

Tom> It was simplest to just fix it.
Tom> Patch appended.

Thanks Tom.  I was away from work most day yesterday that I didn't get
to do this myself.

Thanks,
Siva Chandra