From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91146-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22424 invoked by alias); 15 May 2012 20:26:15 -0000
Received: (qmail 22385 invoked by uid 22791); 15 May 2012 20:26:11 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 May 2012 20:25:54 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4FKProh022225	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 15 May 2012 16:25:53 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4FKPqqd031358	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 15 May 2012 16:25:53 -0400
From: Tom Tromey <tromey@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: New ARI warning Mon May 14 01:55:48 UTC 2012
References: <20120514015548.GA27497@sourceware.org>	<CAGyQ6gwE9ETtDhmutt+PieVvU7NpUgYuN0-TD+be6fDmgtFvOQ@mail.gmail.com>	<87likuv6yr.fsf@fleche.redhat.com>
Date: Tue, 15 May 2012 20:26:00 -0000
In-Reply-To: <87likuv6yr.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon,	14 May 2012 14:33:00 -0600")
Message-ID: <871umltcmn.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00588.txt.bz2

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> GDB_PY_LLU_ARG should be used with gdb_py_ulongest.  What this type
Tom> refers to depends on configure.  It is done this way to let us handle
Tom> multiple Python versions in the same sources.  Your patch probably
Tom> breaks on some version or another.  See python-internal.h.

It was simplest to just fix it.
Patch appended.

Tom

2012-05-15  Tom Tromey  <tromey@redhat.com>

	* python/python.c (gdbpy_find_pc_line): Use gdb_py_ulongest.

Index: python/python.c
===================================================================
RCS file: /cvs/src/src/gdb/python/python.c,v
retrieving revision 1.88
diff -u -r1.88 python.c
--- python/python.c	14 May 2012 03:06:47 -0000	1.88
+++ python/python.c	15 May 2012 20:25:15 -0000
@@ -639,7 +639,7 @@
 {
   struct symtab_and_line sal;
   CORE_ADDR pc;
-  ULONGEST pc_llu;
+  gdb_py_ulongest pc_llu;
 
   if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc_llu))
     return NULL;