From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91104-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20088 invoked by alias); 14 May 2012 20:33:23 -0000
Received: (qmail 19947 invoked by uid 22791); 14 May 2012 20:33:20 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 May 2012 20:33:03 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4EKX2JO008918	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 14 May 2012 16:33:02 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4EKX0xI032483	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 14 May 2012 16:33:01 -0400
From: Tom Tromey <tromey@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: New ARI warning Mon May 14 01:55:48 UTC 2012
References: <20120514015548.GA27497@sourceware.org>	<CAGyQ6gwE9ETtDhmutt+PieVvU7NpUgYuN0-TD+be6fDmgtFvOQ@mail.gmail.com>
Date: Mon, 14 May 2012 20:33:00 -0000
In-Reply-To: <CAGyQ6gwE9ETtDhmutt+PieVvU7NpUgYuN0-TD+be6fDmgtFvOQ@mail.gmail.com>	(Siva Chandra's message of "Mon, 14 May 2012 08:39:45 +0530")
Message-ID: <87likuv6yr.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00546.txt.bz2

>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:

Siva>         * python/python.c (gdbpy_find_pc_line): Use ULONGEST instead of
Siva>         unsigned long long.

Siva> -  unsigned long long pc_llu;
Siva> +  ULONGEST pc_llu;
 
Siva>    if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc_llu))
Siva>      return NULL;

GDB_PY_LLU_ARG should be used with gdb_py_ulongest.  What this type
refers to depends on configure.  It is done this way to let us handle
multiple Python versions in the same sources.  Your patch probably
breaks on some version or another.  See python-internal.h.

Tom