Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: New ARI warning Mon May 14 01:55:48 UTC 2012
Date: Tue, 15 May 2012 20:26:00 -0000	[thread overview]
Message-ID: <871umltcmn.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87likuv6yr.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon,	14 May 2012 14:33:00 -0600")

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> GDB_PY_LLU_ARG should be used with gdb_py_ulongest.  What this type
Tom> refers to depends on configure.  It is done this way to let us handle
Tom> multiple Python versions in the same sources.  Your patch probably
Tom> breaks on some version or another.  See python-internal.h.

It was simplest to just fix it.
Patch appended.

Tom

2012-05-15  Tom Tromey  <tromey@redhat.com>

	* python/python.c (gdbpy_find_pc_line): Use gdb_py_ulongest.

Index: python/python.c
===================================================================
RCS file: /cvs/src/src/gdb/python/python.c,v
retrieving revision 1.88
diff -u -r1.88 python.c
--- python/python.c	14 May 2012 03:06:47 -0000	1.88
+++ python/python.c	15 May 2012 20:25:15 -0000
@@ -639,7 +639,7 @@
 {
   struct symtab_and_line sal;
   CORE_ADDR pc;
-  ULONGEST pc_llu;
+  gdb_py_ulongest pc_llu;
 
   if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc_llu))
     return NULL;


  reply	other threads:[~2012-05-15 20:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14  1:56 GDB Administrator
2012-05-14  3:10 ` Siva Chandra
2012-05-14 20:33   ` Tom Tromey
2012-05-15 20:26     ` Tom Tromey [this message]
2012-05-16  3:12       ` Siva Chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871umltcmn.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sivachandra@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox