From: Tom Tromey <tromey@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: New ARI warning Mon May 14 01:55:48 UTC 2012
Date: Mon, 14 May 2012 20:33:00 -0000 [thread overview]
Message-ID: <87likuv6yr.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAGyQ6gwE9ETtDhmutt+PieVvU7NpUgYuN0-TD+be6fDmgtFvOQ@mail.gmail.com> (Siva Chandra's message of "Mon, 14 May 2012 08:39:45 +0530")
>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
Siva> * python/python.c (gdbpy_find_pc_line): Use ULONGEST instead of
Siva> unsigned long long.
Siva> - unsigned long long pc_llu;
Siva> + ULONGEST pc_llu;
Siva> if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc_llu))
Siva> return NULL;
GDB_PY_LLU_ARG should be used with gdb_py_ulongest. What this type
refers to depends on configure. It is done this way to let us handle
multiple Python versions in the same sources. Your patch probably
breaks on some version or another. See python-internal.h.
Tom
next prev parent reply other threads:[~2012-05-14 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 1:56 GDB Administrator
2012-05-14 3:10 ` Siva Chandra
2012-05-14 20:33 ` Tom Tromey [this message]
2012-05-15 20:26 ` Tom Tromey
2012-05-16 3:12 ` Siva Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87likuv6yr.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox