From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] native mingw32 gdb, eol format
Date: Tue, 16 Jul 2013 02:50:00 -0000 [thread overview]
Message-ID: <83ppuj2p7r.fsf@gnu.org> (raw)
In-Reply-To: <1373936767-14858-1-git-send-email-yao@codesourcery.com>
> From: Yao Qi <yao@codesourcery.com>
> Date: Tue, 16 Jul 2013 09:06:07 +0800
>
> This patch, which was written by Pedro, is to force stdout/stderr to
> binary mode prevents that expansion. This patch gets much
> improvement on the test result of mingw native gdb. Is it OK?
No, it's not. A MinGW GDB is a native Windows program, and should
behave like one. Windows programs generally don't expect text coming
through pipes to have Unix EOL format. Also, it is terribly confusing
to have GDB behave differently with its standard handles redirected to
a pipe as opposed to disk files or the console device.
This is a problem with the test suite, so please fix it in the test
suite. If you _must_ make the change in GDB, please introduce some
specialized option to do that. But changing the default behavior like
that is IMO a no-starter.
next prev parent reply other threads:[~2013-07-16 2:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 1:07 Yao Qi
2013-07-16 2:50 ` Eli Zaretskii [this message]
2013-07-20 0:38 ` Yao Qi
2013-07-20 6:55 ` Eli Zaretskii
2013-07-23 19:03 ` Tom Tromey
2013-07-23 19:08 ` Eli Zaretskii
2013-07-23 20:58 ` Tom Tromey
2013-07-24 3:46 ` Eli Zaretskii
2013-07-24 9:09 ` Yao Qi
2013-09-17 13:07 ` [PATCH 0/4] Match \r\r\n in testsuite Yao Qi
2013-09-17 13:07 ` [PATCH 1/4] Use gdb_test_sequence to test "info tracepoints" Yao Qi
2013-09-17 13:07 ` [PATCH 4/4] Replace "." with "\r+" Yao Qi
2013-09-17 13:07 ` [PATCH 2/4] Transform "\r\n" in pattern to "\r+\n" Yao Qi
2013-09-17 23:11 ` Pierre Muller
2013-09-17 13:07 ` [PATCH 3/4] Transform \r\n in MI variables Yao Qi
2013-09-17 13:35 ` [PATCH 0/4] Match \r\r\n in testsuite Joel Brobecker
2013-09-17 13:59 ` Yao Qi
2013-09-17 14:06 ` Joel Brobecker
2013-09-18 8:21 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ppuj2p7r.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox