Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 0/4] Match \r\r\n in testsuite
Date: Tue, 17 Sep 2013 13:07:00 -0000	[thread overview]
Message-ID: <1379423179-8515-1-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <87a9ldyu8k.fsf@fleche.redhat.com>

This is a follow-up to the thread

  [PATCH] native mingw32 gdb, eol format
  https://sourceware.org/ml/gdb-patches/2013-07/msg00358.html

At the very beginning, I proposed to either add a new option or set
stderr/stdout to binary mode, neither is acceptable because of its
drawback.  We don't want to add a new option only for running
testsuite on a certain configuration, and don't want to change GDB's
output behavior.

Then, I restarted from the beginning again, and see if we can fix the
problem by modifying testsuite.  The requirement expressed in the
previous patch review is that we should localize the changes to
testsuite to match \r\r\n.

This patch series is to change testsuite to match both \r\n and
\r\r\n by modifying pattern to \r+\n in a localized manner.  Patch 1/4
is to replace gdb_test with gdb_test_sequence to match the output of
"info tracepoints", so that the assumption of last character of each
line is removed, so these patterns can be matched on all targets.
Patch 2/4 is to transform \r\n in patterns to \r+\n, but \r\n in
variables can't be transformed.  Patch 3/4 transforms \r\n in variables.

The whole series are tested on mingw32 native gdb, and compared with
running gdb with stdout/stderr setting to binary mode.  No extra fails.

*** BLURB HERE ***

Yao Qi (4):
  Use gdb_test_sequence to test "info tracepoints"
  Transform "\r\n" in pattern to "\r+\n"
  Transform \r\n in MI variables
  Replace "." with "\r+".

 gdb/testsuite/gdb.trace/actions.exp        |  119 +++++++++--------
 gdb/testsuite/gdb.trace/deltrace.exp       |   78 ++++++------
 gdb/testsuite/gdb.trace/infotrace.exp      |   36 +++---
 gdb/testsuite/gdb.trace/passcount.exp      |  200 ++++++++++++++-------------
 gdb/testsuite/gdb.trace/tracecmd.exp       |   12 +-
 gdb/testsuite/gdb.trace/while-stepping.exp |   25 ++--
 gdb/testsuite/lib/gdb.exp                  |   22 +++
 gdb/testsuite/lib/mi-support.exp           |   12 +-
 8 files changed, 273 insertions(+), 231 deletions(-)

-- 
1.7.7.6


  parent reply	other threads:[~2013-09-17 13:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16  1:07 [PATCH] native mingw32 gdb, eol format Yao Qi
2013-07-16  2:50 ` Eli Zaretskii
2013-07-20  0:38   ` Yao Qi
2013-07-20  6:55     ` Eli Zaretskii
2013-07-23 19:03     ` Tom Tromey
2013-07-23 19:08       ` Eli Zaretskii
2013-07-23 20:58         ` Tom Tromey
2013-07-24  3:46           ` Eli Zaretskii
2013-07-24  9:09             ` Yao Qi
2013-09-17 13:07       ` Yao Qi [this message]
2013-09-17 13:07         ` [PATCH 4/4] Replace "." with "\r+" Yao Qi
2013-09-17 13:07         ` [PATCH 1/4] Use gdb_test_sequence to test "info tracepoints" Yao Qi
2013-09-17 13:07         ` [PATCH 3/4] Transform \r\n in MI variables Yao Qi
2013-09-17 13:07         ` [PATCH 2/4] Transform "\r\n" in pattern to "\r+\n" Yao Qi
2013-09-17 23:11           ` Pierre Muller
2013-09-17 13:35         ` [PATCH 0/4] Match \r\r\n in testsuite Joel Brobecker
2013-09-17 13:59           ` Yao Qi
2013-09-17 14:06             ` Joel Brobecker
2013-09-18  8:21               ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379423179-8515-1-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox