From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14477 invoked by alias); 17 Sep 2013 13:07:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14465 invoked by uid 89); 17 Sep 2013 13:07:05 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Sep 2013 13:07:05 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_05,FROM_12LTRDOM,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VLuzc-0004bY-Lz from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Tue, 17 Sep 2013 06:07:00 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 17 Sep 2013 06:07:00 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Tue, 17 Sep 2013 06:06:59 -0700 From: Yao Qi To: Subject: [PATCH 0/4] Match \r\r\n in testsuite Date: Tue, 17 Sep 2013 13:07:00 -0000 Message-ID: <1379423179-8515-1-git-send-email-yao@codesourcery.com> In-Reply-To: <87a9ldyu8k.fsf@fleche.redhat.com> References: <87a9ldyu8k.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00497.txt.bz2 This is a follow-up to the thread [PATCH] native mingw32 gdb, eol format https://sourceware.org/ml/gdb-patches/2013-07/msg00358.html At the very beginning, I proposed to either add a new option or set stderr/stdout to binary mode, neither is acceptable because of its drawback. We don't want to add a new option only for running testsuite on a certain configuration, and don't want to change GDB's output behavior. Then, I restarted from the beginning again, and see if we can fix the problem by modifying testsuite. The requirement expressed in the previous patch review is that we should localize the changes to testsuite to match \r\r\n. This patch series is to change testsuite to match both \r\n and \r\r\n by modifying pattern to \r+\n in a localized manner. Patch 1/4 is to replace gdb_test with gdb_test_sequence to match the output of "info tracepoints", so that the assumption of last character of each line is removed, so these patterns can be matched on all targets. Patch 2/4 is to transform \r\n in patterns to \r+\n, but \r\n in variables can't be transformed. Patch 3/4 transforms \r\n in variables. The whole series are tested on mingw32 native gdb, and compared with running gdb with stdout/stderr setting to binary mode. No extra fails. *** BLURB HERE *** Yao Qi (4): Use gdb_test_sequence to test "info tracepoints" Transform "\r\n" in pattern to "\r+\n" Transform \r\n in MI variables Replace "." with "\r+". gdb/testsuite/gdb.trace/actions.exp | 119 +++++++++-------- gdb/testsuite/gdb.trace/deltrace.exp | 78 ++++++------ gdb/testsuite/gdb.trace/infotrace.exp | 36 +++--- gdb/testsuite/gdb.trace/passcount.exp | 200 ++++++++++++++------------- gdb/testsuite/gdb.trace/tracecmd.exp | 12 +- gdb/testsuite/gdb.trace/while-stepping.exp | 25 ++-- gdb/testsuite/lib/gdb.exp | 22 +++ gdb/testsuite/lib/mi-support.exp | 12 +- 8 files changed, 273 insertions(+), 231 deletions(-) -- 1.7.7.6