From: Yao Qi <yao@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/4] Match \r\r\n in testsuite
Date: Wed, 18 Sep 2013 08:21:00 -0000 [thread overview]
Message-ID: <52396242.9090008@codesourcery.com> (raw)
In-Reply-To: <20130917140603.GK3132@adacore.com>
On 09/17/2013 10:06 PM, Joel Brobecker wrote:
> Can we look at fixing gdb_test to use that $eol instead? Is that
> even necessary? I see the implementation is:
>
> return [gdb_test_multiple $command $message {
> -re "\[\r\n\]*($pattern)\[\r\n\]+$gdb_prompt $" {
> if ![string match "" $message] then {
> pass "$message"
> }
> }
>
> It seems to me that it should match ${eol} already, no?
Yes, this pattern above should match ${eol}. However, how about the
code using gdb_test_mulitiple or gdb_expect to match? We have to fix
them too. We don't want to replace all instances of \r\n with ${eol},
which is painful.
--
Yao (é½å°§)
prev parent reply other threads:[~2013-09-18 8:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 1:07 [PATCH] native mingw32 gdb, eol format Yao Qi
2013-07-16 2:50 ` Eli Zaretskii
2013-07-20 0:38 ` Yao Qi
2013-07-20 6:55 ` Eli Zaretskii
2013-07-23 19:03 ` Tom Tromey
2013-07-23 19:08 ` Eli Zaretskii
2013-07-23 20:58 ` Tom Tromey
2013-07-24 3:46 ` Eli Zaretskii
2013-07-24 9:09 ` Yao Qi
2013-09-17 13:07 ` [PATCH 0/4] Match \r\r\n in testsuite Yao Qi
2013-09-17 13:07 ` [PATCH 1/4] Use gdb_test_sequence to test "info tracepoints" Yao Qi
2013-09-17 13:07 ` [PATCH 4/4] Replace "." with "\r+" Yao Qi
2013-09-17 13:07 ` [PATCH 2/4] Transform "\r\n" in pattern to "\r+\n" Yao Qi
2013-09-17 23:11 ` Pierre Muller
2013-09-17 13:07 ` [PATCH 3/4] Transform \r\n in MI variables Yao Qi
2013-09-17 13:35 ` [PATCH 0/4] Match \r\r\n in testsuite Joel Brobecker
2013-09-17 13:59 ` Yao Qi
2013-09-17 14:06 ` Joel Brobecker
2013-09-18 8:21 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52396242.9090008@codesourcery.com \
--to=yao@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox