From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] Match \r\r\n in testsuite
Date: Tue, 17 Sep 2013 13:35:00 -0000 [thread overview]
Message-ID: <20130917133530.GH3132@adacore.com> (raw)
In-Reply-To: <1379423179-8515-1-git-send-email-yao@codesourcery.com>
> Then, I restarted from the beginning again, and see if we can fix the
> problem by modifying testsuite. The requirement expressed in the
> previous patch review is that we should localize the changes to
> testsuite to match \r\r\n.
>
> This patch series is to change testsuite to match both \r\n and
> \r\r\n by modifying pattern to \r+\n in a localized manner. Patch 1/4
> is to replace gdb_test with gdb_test_sequence to match the output of
> "info tracepoints", so that the assumption of last character of each
> line is removed, so these patterns can be matched on all targets.
> Patch 2/4 is to transform \r\n in patterns to \r+\n, but \r\n in
> variables can't be transformed. Patch 3/4 transforms \r\n in variables.
How about we introduce a new official variable, similar to $hex,
$decimal, etc, which would correctly match new-line output based
on the host? I propose $eol, which is already used, but only in
2 testcases, so easy to adjust (remove "set eol ..." in those two
testcases).
--
Joel
next prev parent reply other threads:[~2013-09-17 13:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 1:07 [PATCH] native mingw32 gdb, eol format Yao Qi
2013-07-16 2:50 ` Eli Zaretskii
2013-07-20 0:38 ` Yao Qi
2013-07-20 6:55 ` Eli Zaretskii
2013-07-23 19:03 ` Tom Tromey
2013-07-23 19:08 ` Eli Zaretskii
2013-07-23 20:58 ` Tom Tromey
2013-07-24 3:46 ` Eli Zaretskii
2013-07-24 9:09 ` Yao Qi
2013-09-17 13:07 ` [PATCH 0/4] Match \r\r\n in testsuite Yao Qi
2013-09-17 13:07 ` [PATCH 3/4] Transform \r\n in MI variables Yao Qi
2013-09-17 13:07 ` [PATCH 2/4] Transform "\r\n" in pattern to "\r+\n" Yao Qi
2013-09-17 23:11 ` Pierre Muller
2013-09-17 13:07 ` [PATCH 4/4] Replace "." with "\r+" Yao Qi
2013-09-17 13:07 ` [PATCH 1/4] Use gdb_test_sequence to test "info tracepoints" Yao Qi
2013-09-17 13:35 ` Joel Brobecker [this message]
2013-09-17 13:59 ` [PATCH 0/4] Match \r\r\n in testsuite Yao Qi
2013-09-17 14:06 ` Joel Brobecker
2013-09-18 8:21 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917133530.GH3132@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox